tests/CanvasTest.cpp - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/CanvasTest.cpp

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/CanvasTest.cpp

diff --git a/tests/CanvasTest.cpp b/tests/CanvasTest.cpp

index 8681ca4f180651823ed2be6f22bbdf73541c9293..05ce60469b5b696b949b02a678e2e691d9c15d9a 100644

--- a/tests/CanvasTest.cpp

+++ b/tests/CanvasTest.cpp

@@ -431,9 +431,8 @@ static void DrawPictureTestStep(SkCanvas* canvas, const TestData& d,

testCanvas->scale(SkIntToScalar(2), SkIntToScalar(1));

testCanvas->clipRect(d.fRect);

testCanvas->drawRect(d.fRect, d.fPaint);

- SkAutoTUnref<SkPicture> testPicture(recorder.endRecording());

- canvas->drawPicture(testPicture);

+ canvas->drawPicture(recorder.finishRecordingAsPicture());

}

TEST_STEP(DrawPicture, DrawPictureTestStep);

« no previous file with comments | « src/utils/SkLua.cpp ('k') | tests/GpuLayerCacheTest.cpp » ('j') | no next file with comments »