samplecode/SampleFilterFuzz.cpp - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SampleFilterFuzz.cpp

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samplecode/SampleFilterFuzz.cpp

diff --git a/samplecode/SampleFilterFuzz.cpp b/samplecode/SampleFilterFuzz.cpp

index 81ea2eaed40d409350710d9c69a2bec57ccdc179..0dd01e95b2f25250bb2f5f8c0e5cbbdc8e979474 100644

--- a/samplecode/SampleFilterFuzz.cpp

+++ b/samplecode/SampleFilterFuzz.cpp

@@ -712,7 +712,7 @@ static SkImageFilter* make_image_filter(bool canBeNull) {

SkIntToScalar(kBitmapSize),

&factory, 0);

drawSomething(recordingCanvas);

- SkAutoTUnref<SkPicture> pict(recorder.endRecording());

+ sk_sp<SkPicture> pict(recorder.finishRecordingAsPicture());

filter = SkPictureImageFilter::Create(pict.get(), make_rect());

}

break;

« no previous file with comments | « samplecode/SampleArc.cpp ('k') | samplecode/SampleHT.cpp » ('j') | no next file with comments »