include/private/SkMiniRecorder.h - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/private/SkMiniRecorder.h

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/private/SkMiniRecorder.h

diff --git a/include/private/SkMiniRecorder.h b/include/private/SkMiniRecorder.h

index 5b68fc22f843e4947462a2a7fba32e390f5b5c02..2f5612ca39f7ba629192f97cd8eb307dae897ce7 100644

--- a/include/private/SkMiniRecorder.h

+++ b/include/private/SkMiniRecorder.h

@@ -27,7 +27,7 @@ public:

bool drawTextBlob(const SkTextBlob*, SkScalar x, SkScalar y, const SkPaint&);

// Detach anything we've recorded as a picture, resetting this SkMiniRecorder.

- SkPicture* detachAsPicture(const SkRect& cull);

+ sk_sp<SkPicture> detachAsPicture(const SkRect& cull);

// Flush anything we've recorded to the canvas, resetting this SkMiniRecorder.

// This is logically the same as but rather more efficient than:

« no previous file with comments | « include/core/SkPictureRecorder.h ('k') | samplecode/SampleAll.cpp » ('j') | no next file with comments »