gm/pathopsskpclip.cpp - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/pathopsskpclip.cpp

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/pathopsskpclip.cpp

diff --git a/gm/pathopsskpclip.cpp b/gm/pathopsskpclip.cpp

index 1c8cf99cb8ed1985da8aff4ecb570f81094d7aa0..b52e8bbc902a934a20ed05b752ca4698c4361518 100644

--- a/gm/pathopsskpclip.cpp

+++ b/gm/pathopsskpclip.cpp

@@ -47,7 +47,7 @@ protected:

rec->translate(SkIntToScalar(250), SkIntToScalar(250));

rec->clipPath(p, SkRegion::kIntersect_Op, true);

rec->drawColor(0xffff0000);

- SkAutoTUnref<SkPicture> pict(recorder.endRecording());

+ sk_sp<SkPicture> pict(recorder.finishRecordingAsPicture());

canvas->setAllowSimplifyClip(true);

canvas->save();

« no previous file with comments | « gm/multipicturedraw.cpp ('k') | gm/picture.cpp » ('j') | no next file with comments »