bench/RecordingBench.cpp - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/RecordingBench.cpp

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bench/RecordingBench.cpp

diff --git a/bench/RecordingBench.cpp b/bench/RecordingBench.cpp

index 1cc4d153450c4c8c16ec18d4d899e6e0a9271314..537c9e158e6127f94566923b96884d29cc4f223c 100644

--- a/bench/RecordingBench.cpp

+++ b/bench/RecordingBench.cpp

@@ -38,6 +38,6 @@ void RecordingBench::onDraw(int loops, SkCanvas*) {

for (int i = 0; i < loops; i++) {

SkPictureRecorder recorder;

fSrc->playback(recorder.beginRecording(w, h, fUseBBH ? &factory : nullptr, flags));

- SkSafeUnref(recorder.endRecording());

+ (void)recorder.finishRecordingAsPicture();

}

« no previous file with comments | « bench/PicturePlaybackBench.cpp ('k') | bench/nanobench.cpp » ('j') | no next file with comments »