Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/core/SkPictureShader.cpp

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/core/SkPictureRecorder.cpp ('k') | src/effects/SkPictureImageFilter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 Google Inc. 2 * Copyright 2014 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkPictureShader.h" 8 #include "SkPictureShader.h"
9 9
10 #include "SkBitmap.h" 10 #include "SkBitmap.h"
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 buffer.validate(false); 126 buffer.validate(false);
127 return nullptr; 127 return nullptr;
128 } 128 }
129 // Newer code won't serialize pictures in disallow-cross-process-picture mode. 129 // Newer code won't serialize pictures in disallow-cross-process-picture mode.
130 // Assert that they didn't serialize anything except a false here. 130 // Assert that they didn't serialize anything except a false here.
131 buffer.validate(!buffer.readBool()); 131 buffer.validate(!buffer.readBool());
132 } else { 132 } else {
133 // Old code always serialized the picture. New code writes a 'true' fir st if it did. 133 // Old code always serialized the picture. New code writes a 'true' fir st if it did.
134 if (buffer.isVersionLT(SkReadBuffer::kPictureShaderHasPictureBool_Versio n) || 134 if (buffer.isVersionLT(SkReadBuffer::kPictureShaderHasPictureBool_Versio n) ||
135 buffer.readBool()) { 135 buffer.readBool()) {
136 picture.reset(SkPicture::CreateFromBuffer(buffer)); 136 picture = SkPicture::MakeFromBuffer(buffer);
137 } 137 }
138 } 138 }
139 return SkPictureShader::Make(picture, mx, my, &lm, &tile).release(); 139 return SkPictureShader::Make(picture, mx, my, &lm, &tile).release();
140 } 140 }
141 141
142 void SkPictureShader::flatten(SkWriteBuffer& buffer) const { 142 void SkPictureShader::flatten(SkWriteBuffer& buffer) const {
143 buffer.writeMatrix(this->getLocalMatrix()); 143 buffer.writeMatrix(this->getLocalMatrix());
144 buffer.write32(fTmx); 144 buffer.write32(fTmx);
145 buffer.write32(fTmy); 145 buffer.write32(fTmy);
146 buffer.writeRect(fTile); 146 buffer.writeRect(fTile);
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 if (context) { 327 if (context) {
328 maxTextureSize = context->caps()->maxTextureSize(); 328 maxTextureSize = context->caps()->maxTextureSize();
329 } 329 }
330 sk_sp<SkShader> bitmapShader(this->refBitmapShader(viewM, localMatrix, maxTe xtureSize)); 330 sk_sp<SkShader> bitmapShader(this->refBitmapShader(viewM, localMatrix, maxTe xtureSize));
331 if (!bitmapShader) { 331 if (!bitmapShader) {
332 return nullptr; 332 return nullptr;
333 } 333 }
334 return bitmapShader->asFragmentProcessor(context, viewM, nullptr, fq); 334 return bitmapShader->asFragmentProcessor(context, viewM, nullptr, fq);
335 } 335 }
336 #endif 336 #endif
OLDNEW
« no previous file with comments | « src/core/SkPictureRecorder.cpp ('k') | src/effects/SkPictureImageFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698