Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: test/mjsunit/regress/regress-v8-4839.js

Issue 1811693002: [crankshaft] Fix inlining to always connect both branches of test context. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 // Flags: --allow-natives-syntax
6
7 function dummy() { }
8
9 (function InlinedFunctionTestContext() {
10 var f = function() { }
11
12 function g() {
13 var s = "hey";
14 dummy(); // Force a deopt point.
15 if (f()) return s;
16 }
17
18 g();
19 g();
20 g();
21 %OptimizeFunctionOnNextCall(g);
22 f = function() { return true; }
23 assertEquals("hey", g());
24 })();
25
26 (function InlinedConstructorReturnTestContext() {
27 function c() { return 1; }
28
29 var f = function() { return !(new c()); }
30
31 function g() {
32 var s = "hey";
33 dummy(); // Force a deopt point.
34 if (f()) return s;
35 }
36
37 g();
38 g();
39 g();
40 %OptimizeFunctionOnNextCall(g);
41 f = function() { return true; }
42 assertEquals("hey", g());
43 })();
44
45 (function InlinedConstructorNoReturnTestContext() {
46 function c() { }
47
48 var f = function() { return !(new c()); }
Jakob Kummerow 2016/03/17 09:54:03 This looks identical to the InlinedConstructorRetu
Jakob Kummerow 2016/03/17 09:55:38 Nvm, I see function c() is different.
49
50 function g() {
51 var s = "hey";
52 dummy(); // Force a deopt point.
53 if (f()) return s;
54 }
55
56 g();
57 g();
58 g();
59 %OptimizeFunctionOnNextCall(g);
60 f = function() { return true; }
61 assertEquals("hey", g());
62 })();
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698