Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1811693002: [crankshaft] Fix inlining to always connect both branches of test context. (Closed)

Created:
4 years, 9 months ago by Jarin
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Fix inlining to always connect both branches of test context. BUG=v8:4839 LOG=n Committed: https://crrev.com/c2e82d6e828a6108e1599cc5da79ec2d63291ecc Cr-Commit-Position: refs/heads/master@{#34848}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -4 lines) Patch
M src/crankshaft/hydrogen.cc View 3 chunks +3 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-v8-4839.js View 1 chunk +62 lines, -0 lines 2 comments Download

Messages

Total messages: 9 (3 generated)
Jarin
Could you take a look, please?
4 years, 9 months ago (2016-03-16 20:55:23 UTC) #2
Jakob Kummerow
LGTM with nit. https://codereview.chromium.org/1811693002/diff/1/test/mjsunit/regress/regress-v8-4839.js File test/mjsunit/regress/regress-v8-4839.js (right): https://codereview.chromium.org/1811693002/diff/1/test/mjsunit/regress/regress-v8-4839.js#newcode48 test/mjsunit/regress/regress-v8-4839.js:48: var f = function() { return ...
4 years, 9 months ago (2016-03-17 09:54:04 UTC) #3
Jakob Kummerow
https://codereview.chromium.org/1811693002/diff/1/test/mjsunit/regress/regress-v8-4839.js File test/mjsunit/regress/regress-v8-4839.js (right): https://codereview.chromium.org/1811693002/diff/1/test/mjsunit/regress/regress-v8-4839.js#newcode48 test/mjsunit/regress/regress-v8-4839.js:48: var f = function() { return !(new c()); } ...
4 years, 9 months ago (2016-03-17 09:55:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811693002/1
4 years, 9 months ago (2016-03-17 09:57:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 09:59:05 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 10:00:26 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c2e82d6e828a6108e1599cc5da79ec2d63291ecc
Cr-Commit-Position: refs/heads/master@{#34848}

Powered by Google App Engine
This is Rietveld 408576698