Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: src/heap/mark-compact.cc

Issue 1811653002: Re-enable parallel pointer updates. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/mark-compact.h" 5 #include "src/heap/mark-compact.h"
6 6
7 #include "src/base/atomicops.h" 7 #include "src/base/atomicops.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/base/sys-info.h" 9 #include "src/base/sys-info.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 3567 matching lines...) Expand 10 before | Expand all | Expand 10 after
3578 3578
3579 int NumberOfPointerUpdateTasks(int pages) { 3579 int NumberOfPointerUpdateTasks(int pages) {
3580 if (!FLAG_parallel_pointer_update) return 1; 3580 if (!FLAG_parallel_pointer_update) return 1;
3581 const int kMaxTasks = 4; 3581 const int kMaxTasks = 4;
3582 const int kPagesPerTask = 4; 3582 const int kPagesPerTask = 4;
3583 return Min(kMaxTasks, (pages + kPagesPerTask - 1) / kPagesPerTask); 3583 return Min(kMaxTasks, (pages + kPagesPerTask - 1) / kPagesPerTask);
3584 } 3584 }
3585 3585
3586 template <PointerDirection direction> 3586 template <PointerDirection direction>
3587 void UpdatePointersInParallel(Heap* heap) { 3587 void UpdatePointersInParallel(Heap* heap) {
3588 PageParallelJob<PointerUpdateJobTraits<direction> > job( 3588 PageParallelJob<PointerUpdateJobTraits<direction> >* job =
3589 heap, heap->isolate()->cancelable_task_manager()); 3589 new PageParallelJob<PointerUpdateJobTraits<direction> >(
3590 heap, heap->isolate()->cancelable_task_manager());
3590 RememberedSet<direction>::IterateMemoryChunks( 3591 RememberedSet<direction>::IterateMemoryChunks(
3591 heap, [&job](MemoryChunk* chunk) { job.AddPage(chunk, 0); }); 3592 heap, [job](MemoryChunk* chunk) { job->AddPage(chunk, 0); });
3592 PointersUpdatingVisitor visitor(heap); 3593 PointersUpdatingVisitor visitor(heap);
3593 int num_pages = job.NumberOfPages(); 3594 int num_pages = job->NumberOfPages();
3594 int num_tasks = NumberOfPointerUpdateTasks(num_pages); 3595 int num_tasks = NumberOfPointerUpdateTasks(num_pages);
3595 job.Run(num_tasks, [&visitor](int i) { return &visitor; }); 3596 job->Run(num_tasks, [&visitor](int i) { return &visitor; });
3597 delete job;
3596 } 3598 }
3597 3599
3598 void MarkCompactCollector::UpdatePointersAfterEvacuation() { 3600 void MarkCompactCollector::UpdatePointersAfterEvacuation() {
3599 GCTracer::Scope gc_scope(heap()->tracer(), 3601 GCTracer::Scope gc_scope(heap()->tracer(),
3600 GCTracer::Scope::MC_EVACUATE_UPDATE_POINTERS); 3602 GCTracer::Scope::MC_EVACUATE_UPDATE_POINTERS);
3601 3603
3602 PointersUpdatingVisitor updating_visitor(heap()); 3604 PointersUpdatingVisitor updating_visitor(heap());
3603 3605
3604 { 3606 {
3605 GCTracer::Scope gc_scope( 3607 GCTracer::Scope gc_scope(
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
3877 MarkBit mark_bit = Marking::MarkBitFrom(host); 3879 MarkBit mark_bit = Marking::MarkBitFrom(host);
3878 if (Marking::IsBlack(mark_bit)) { 3880 if (Marking::IsBlack(mark_bit)) {
3879 RelocInfo rinfo(isolate(), pc, RelocInfo::CODE_TARGET, 0, host); 3881 RelocInfo rinfo(isolate(), pc, RelocInfo::CODE_TARGET, 0, host);
3880 RecordRelocSlot(host, &rinfo, target); 3882 RecordRelocSlot(host, &rinfo, target);
3881 } 3883 }
3882 } 3884 }
3883 } 3885 }
3884 3886
3885 } // namespace internal 3887 } // namespace internal
3886 } // namespace v8 3888 } // namespace v8
OLDNEW
« no previous file with comments | « src/flag-definitions.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698