Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1811643002: Add File.readAsBytesSync/writeAsBytesSync() methods. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -15 lines) Patch
M pkg/analyzer/lib/file_system/file_system.dart View 2 chunks +14 lines, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/memory_file_system.dart View 7 chunks +58 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/file_system/physical_file_system.dart View 3 chunks +22 lines, -2 lines 0 comments Download
M pkg/analyzer/test/file_system/memory_file_system_test.dart View 3 chunks +31 lines, -0 lines 0 comments Download
M pkg/analyzer/test/file_system/physical_resource_provider_test.dart View 3 chunks +26 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-16 18:12:56 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-16 18:20:24 UTC) #2
scheglov
4 years, 9 months ago (2016-03-16 18:22:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
45711829f6e5f4e948a73df927acb445ff5e11db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698