Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1811633002: [iOS] Define bundle_data target for //sql:sql_unittests. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@net
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Define bundle_data target for //sql:sql_unittests. This ensure that the files required by sql_unittests application will be copied into the application bundle on iOS. BUG=297668 Committed: https://crrev.com/c374755600bbe9135a3c3db738ce3b0f3fdc8fdd Cr-Commit-Position: refs/heads/master@{#381976}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mark bundle_data as testonly #

Patch Set 3 : Rebase on origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M sql/BUILD.gn View 1 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sdefresne
dpranke: Please take a look. gbillock: Could you review as OWNERS?
4 years, 9 months ago (2016-03-16 18:09:31 UTC) #2
Dirk Pranke
lgtm https://codereview.chromium.org/1811633002/diff/1/sql/BUILD.gn File sql/BUILD.gn (right): https://codereview.chromium.org/1811633002/diff/1/sql/BUILD.gn#newcode74 sql/BUILD.gn:74: "test/data", nit: please use a trailing slash, assuming ...
4 years, 9 months ago (2016-03-16 22:03:42 UTC) #3
sdefresne
gbillock: ping? https://codereview.chromium.org/1811633002/diff/1/sql/BUILD.gn File sql/BUILD.gn (right): https://codereview.chromium.org/1811633002/diff/1/sql/BUILD.gn#newcode74 sql/BUILD.gn:74: "test/data", On 2016/03/16 at 22:03:42, Dirk Pranke ...
4 years, 9 months ago (2016-03-17 17:54:00 UTC) #4
sdefresne
-gbillock, +shess: Can you give OWNERS review?
4 years, 9 months ago (2016-03-18 10:17:13 UTC) #6
Scott Hess - ex-Googler
lgtm
4 years, 9 months ago (2016-03-18 14:30:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811633002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811633002/40001
4 years, 9 months ago (2016-03-18 15:39:27 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-18 15:44:08 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 15:46:12 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c374755600bbe9135a3c3db738ce3b0f3fdc8fdd
Cr-Commit-Position: refs/heads/master@{#381976}

Powered by Google App Engine
This is Rietveld 408576698