Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1811613005: Re-land: Enable XFA-Forms for the PDFium plugin. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
stevenjb, Nico
CC:
chromium-reviews, rpop, jschuh
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Enable XFA-Forms for the PDFium plugin. But not on Chrome OS. This reverts commit 7812fb8ba8271fbc542fd5716498517b82ba821a. BUG=62400 Committed: https://crrev.com/8ecd31ca0b8549f27f9b0f5a3d07d4eed1101538 Cr-Commit-Position: refs/heads/master@{#381811}

Patch Set 1 : Original Patch #

Patch Set 2 : But not chromeos #

Patch Set 3 : Fix logic. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M build/common.gypi View 1 2 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Tom Sepez
Nico, please review.
4 years, 9 months ago (2016-03-17 19:53:25 UTC) #3
Nico
lgtm
4 years, 9 months ago (2016-03-17 20:03:54 UTC) #4
Nico
(btw, would've been nice to have a tracking bug for this. As-is, it's going to ...
4 years, 9 months ago (2016-03-17 20:04:31 UTC) #5
Tom Sepez
My bad, forgot to set BUG= in these.
4 years, 9 months ago (2016-03-17 20:25:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811613005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811613005/40001
4 years, 9 months ago (2016-03-17 20:26:13 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-17 22:37:14 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 22:39:31 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8ecd31ca0b8549f27f9b0f5a3d07d4eed1101538
Cr-Commit-Position: refs/heads/master@{#381811}

Powered by Google App Engine
This is Rietveld 408576698