Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1811613003: docs: codeblock within a list should be indented (Closed)

Created:
4 years, 9 months ago by tfarina
Modified:
4 years, 9 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

docs: codeblock within a list should be indented According to the style guide a nested codeblock within a list, which is the case we are changing here, should be indented, otherwise it will break the numbering of the list, like it is now. Without this indentation the numbering looks like: 1., 2., 1.. But that is just wrong, and should be 1., 2., 3.. The indentation should restore the right numbering here. https://github.com/google/styleguide/blob/gh-pages/docguide/style.md#nest-codeblocks-within-lists BUG=None R=sdefresne@chromium.org Committed: https://crrev.com/f851b2c93ead8b3404ccfb250f861efa7fedf355 Cr-Commit-Position: refs/heads/master@{#381742}

Patch Set 1 #

Patch Set 2 : indent 3 as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M docs/ios_build_instructions.md View 1 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tfarina
4 years, 9 months ago (2016-03-17 16:21:11 UTC) #1
sdefresne
lgtm nit: in the description "Accordding" -> "According"
4 years, 9 months ago (2016-03-17 17:30:38 UTC) #2
tfarina
On 2016/03/17 17:30:38, sdefresne wrote: > lgtm > > nit: in the description "Accordding" -> ...
4 years, 9 months ago (2016-03-17 17:44:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811613003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811613003/20001
4 years, 9 months ago (2016-03-17 17:46:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-17 17:55:19 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 17:56:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f851b2c93ead8b3404ccfb250f861efa7fedf355
Cr-Commit-Position: refs/heads/master@{#381742}

Powered by Google App Engine
This is Rietveld 408576698