Timeline API fixes for Flutter

Timeline API fixes for Flutter

API changes:

- Remove isolate specific Timeline APIs.
- Remove Dart_EmbedderTimelineGetTimeline callback.
- Add Dart_TimelineEvent so that arbitrary trace events can be added.

Internal changes:

- Remove isolate specific streams which were never used or controllable from outside the VM.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/c65114b6b4601511186fa75100bda9b4e0e85b40

[Cutch, 2016-03-16 17:18:26]

Description was changed from

==========
Timeline API fixes for Flutter

BUG=
==========

to

==========
Timeline API fixes for Flutter

API changes:

- Remove isolate specific Timeline APIs.
- Remove Dart_EmbedderTimelineGetTimeline callback.
- Add Dart_TimelineEvent so that arbitrary trace events can be added.

Internal changes:

- Remove isolate specific streams which were never used or controllable from
outside the VM.
==========

[Cutch, 2016-03-16 17:18:26]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-03-16 17:51:30]

lgtm w/ suggestion

https://codereview.chromium.org/1811613002/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1811613002/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:5997: FATAL1("%s: start_micros must be <=
end_micros", CURRENT_FUNC);
Even though these functions can't use handles anymore, they could report errors
with char* like Dart_Initialize/Dart_Cleanup.

[Chinmay, 2016-03-16 18:15:00]

On 2016/03/16 at 17:19:00, johnmccutchan wrote:
> 

Just to clarify, do these |Dart_Timeline_Event_Type| enum value mappings make
sense?

Dart_Timeline_Event_Begin: Maps to the duration begin phase ('B')
Dart_Timeline_Event_End: Maps to the duration end phase ('E')
Dart_Timeline_Event_Instant: Maps to the instant event phase ('i' or 'I')
Dart_Timeline_Event_Duration: Maps to a complete duration event phase ('X')

These values are taken from the reference
https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAy...

If so, it would be great to document these.

Chinmay

[Cutch, 2016-03-16 18:21:50]

On 2016/03/16 18:15:00, Chinmay wrote:
> On 2016/03/16 at 17:19:00, johnmccutchan wrote:
> > 
> 
> Just to clarify, do these |Dart_Timeline_Event_Type| enum value mappings make
> sense?
> 
> Dart_Timeline_Event_Begin: Maps to the duration begin phase ('B')
> Dart_Timeline_Event_End: Maps to the duration end phase ('E')
> Dart_Timeline_Event_Instant: Maps to the instant event phase ('i' or 'I')
> Dart_Timeline_Event_Duration: Maps to a complete duration event phase ('X')
> 

I've added comments to the enum

[Cutch, 2016-03-16 18:24:08]

https://codereview.chromium.org/1811613002/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1811613002/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:5997: FATAL1("%s: start_micros must be <=
end_micros", CURRENT_FUNC);
On 2016/03/16 17:51:30, rmacnak wrote:
> Even though these functions can't use handles anymore, they could report
errors
> with char* like Dart_Initialize/Dart_Cleanup.

I had the same thought but decided to do it only when an API consumer needs it.

[Cutch, 2016-03-16 19:18:50]

Description was changed from

==========
Timeline API fixes for Flutter

API changes:

- Remove isolate specific Timeline APIs.
- Remove Dart_EmbedderTimelineGetTimeline callback.
- Add Dart_TimelineEvent so that arbitrary trace events can be added.

Internal changes:

- Remove isolate specific streams which were never used or controllable from
outside the VM.
==========

to

==========
Timeline API fixes for Flutter

API changes:

- Remove isolate specific Timeline APIs.
- Remove Dart_EmbedderTimelineGetTimeline callback.
- Add Dart_TimelineEvent so that arbitrary trace events can be added.

Internal changes:

- Remove isolate specific streams which were never used or controllable from
outside the VM.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c65114b6b4601511186fa75100bda9b4e0e85b40
==========

[Cutch, 2016-03-16 19:18:51]

Committed patchset #2 (id:20001) manually as
c65114b6b4601511186fa75100bda9b4e0e85b40 (presubmit successful).