Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1811573002: [heap] Remove LocalStoreBuffer and add slots in parallel (Closed)

Created:
4 years, 9 months ago by Michael Lippautz
Modified:
4 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@new-flist
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove LocalStoreBuffer and add slots in parallel Now that we have page-local remembered sets (due to refilling in page granularity) we can perform all updates on the sets during compaction in parallel without caching slots locally. BUG=chromium:524425 LOG=N NOTRY=true Committed: https://crrev.com/fdb0784d0a050ad6d511cdfb9c6e031da01efd05 Cr-Commit-Position: refs/heads/master@{#34952}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -212 lines) Patch
M src/heap/mark-compact.h View 1 3 chunks +1 line, -9 lines 0 comments Download
M src/heap/mark-compact.cc View 1 14 chunks +31 lines, -77 lines 0 comments Download
M src/heap/remembered-set.h View 1 1 chunk +0 lines, -80 lines 0 comments Download
D test/unittests/heap/remembered-set-unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (17 generated)
Michael Lippautz
PTAL
4 years, 9 months ago (2016-03-21 09:35:32 UTC) #8
ulan
lgtm!
4 years, 9 months ago (2016-03-21 09:58:17 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811573002/60001
4 years, 9 months ago (2016-03-21 10:00:14 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/15531)
4 years, 9 months ago (2016-03-21 12:22:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811573002/60001
4 years, 9 months ago (2016-03-21 12:32:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811573002/60001
4 years, 9 months ago (2016-03-21 14:51:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811573002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811573002/60001
4 years, 9 months ago (2016-03-21 15:46:36 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:60001)
4 years, 9 months ago (2016-03-21 16:00:19 UTC) #24
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 16:01:15 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fdb0784d0a050ad6d511cdfb9c6e031da01efd05
Cr-Commit-Position: refs/heads/master@{#34952}

Powered by Google App Engine
This is Rietveld 408576698