test/cctest/test-heap-profiler.cc - Issue 1811553003: [Interpreter] Make ignition compiler eagerly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 1811553003: [Interpreter] Make ignition compiler eagerly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Address review comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index 536dd9cb3a8af8435330eefdae411dded24d260b..a68868c8398a273b126ec257d7278f5f0932c694 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -367,7 +367,9 @@ TEST(HeapSnapshotCodeObjects) {

}

CHECK(compiled_references_x);

- CHECK(!lazy_references_x);

+ if (i::FLAG_lazy && !i::FLAG_ignition) {

Michael Starzinger 2016/03/24 13:27:14 nit: Can we also check for "FLAG_ignition_eager" h

rmcilroy 2016/03/24 13:48:25 Missed this, good catch, thanks. Done

+ CHECK(!lazy_references_x);

+ }

}

« no previous file with comments | « test/cctest/test-compiler.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »