Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3368)

Unified Diff: test/cctest/test-parsing.cc

Issue 1811553003: [Interpreter] Make ignition compiler eagerly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 276cc86bd340ef4485c721a644be9f36b640afcf..d880b78ab9f474a29a590bfe9cd9683c11f7cd11 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -200,6 +200,9 @@ class ScriptResource : public v8::String::ExternalOneByteStringResource {
TEST(UsingCachedData) {
+ // Producing cached parser data while parsing eagerly is not supported.
+ if (!i::FLAG_lazy || i::FLAG_ignition) return;
+
v8::Isolate* isolate = CcTest::isolate();
v8::HandleScope handles(isolate);
v8::Local<v8::Context> context = v8::Context::New(isolate);
@@ -250,6 +253,9 @@ TEST(UsingCachedData) {
TEST(PreparseFunctionDataIsUsed) {
+ // Producing cached parser data while parsing eagerly is not supported.
+ if (!i::FLAG_lazy || i::FLAG_ignition) return;
+
// This tests that we actually do use the function data generated by the
// preparser.
@@ -3238,6 +3244,9 @@ TEST(FuncNameInferrerEscaped) {
TEST(RegressionLazyFunctionWithErrorWithArg) {
+ // Test only applies when lazy parsing.
+ if (!i::FLAG_lazy || i::FLAG_ignition) return;
+
// The bug occurred when a lazy function had an error which requires a
// parameter (such as "unknown label" here). The error message was processed
// before the AstValueFactory containing the error message string was

Powered by Google App Engine
This is Rietveld 408576698