Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: test/cctest/test-compiler.cc

Issue 1811553003: [Interpreter] Make ignition compiler eagerly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-compiler.cc
diff --git a/test/cctest/test-compiler.cc b/test/cctest/test-compiler.cc
index 1dd46bec3e1ce4945c37e12ad5a35f1198918c91..25cf83004b2eb4498b635609344bdeaaddf62c21 100644
--- a/test/cctest/test-compiler.cc
+++ b/test/cctest/test-compiler.cc
@@ -349,9 +349,12 @@ TEST(FeedbackVectorUnaffectedByScopeChanges) {
->Get(context, v8_str("morphing_call"))
.ToLocalChecked())));
- // Not compiled, and so no feedback vector allocated yet.
- CHECK(!f->shared()->is_compiled());
- CHECK(f->shared()->feedback_vector()->is_empty());
+ if (FLAG_lazy && !FLAG_ignition) {
+ // If we are compiling lazily then it should not be compiled, and so no
+ // feedback vector allocated yet.
+ CHECK(!f->shared()->is_compiled());
+ CHECK(f->shared()->feedback_vector()->is_empty());
+ }
CompileRun("morphing_call();");

Powered by Google App Engine
This is Rietveld 408576698