Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: src/compiler.cc

Issue 1811553003: [Interpreter] Make ignition compiler eagerly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/background-parsing-task.cc ('k') | test/cctest/cctest.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index ee8f72bc0af7e73e6b2f32b8d39c589e6364679f..1479b9953c6ed2df1b4c8b12db6d5e663dc6da3d 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -1276,6 +1276,9 @@ Handle<SharedFunctionInfo> CompileToplevel(CompilationInfo* info) {
// Consider parsing eagerly when targeting the code cache.
parse_allow_lazy &= !(FLAG_serialize_eager && info->will_serialize());
+ // Consider parsing eagerly when targeting Ignition.
+ parse_allow_lazy &= !(FLAG_ignition && !isolate->serializer_enabled());
Yang 2016/03/23 14:29:11 Not sure whether we need the serializer_enabled pa
rmcilroy 2016/03/24 11:30:45 Yeah, the issue here is that if we eagerly compile
+
parse_info->set_allow_lazy_parsing(parse_allow_lazy);
if (!parse_allow_lazy &&
(options == ScriptCompiler::kProduceParserCache ||
@@ -1791,6 +1794,9 @@ Handle<SharedFunctionInfo> Compiler::GetSharedFunctionInfo(
// Consider compiling eagerly when targeting the code cache.
lazy &= !(FLAG_serialize_eager && info.will_serialize());
+ // Consider compiling eagerly when compiling bytecode for Ignition.
+ lazy &= !(FLAG_ignition && !isolate->serializer_enabled());
+
// Generate code
TimerEventScope<TimerEventCompileCode> timer(isolate);
TRACE_EVENT0("v8", "V8.CompileCode");
« no previous file with comments | « src/background-parsing-task.cc ('k') | test/cctest/cctest.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698