Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: test/cctest/test-compiler.cc

Issue 1811553003: [Interpreter] Make ignition compiler eagerly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix test which was missed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-compiler.cc
diff --git a/test/cctest/test-compiler.cc b/test/cctest/test-compiler.cc
index 1dd46bec3e1ce4945c37e12ad5a35f1198918c91..32d720e24e5f35961d03c319ae5b61e1139af289 100644
--- a/test/cctest/test-compiler.cc
+++ b/test/cctest/test-compiler.cc
@@ -327,7 +327,10 @@ TEST(FeedbackVectorPreservedAcrossRecompiles) {
TEST(FeedbackVectorUnaffectedByScopeChanges) {
- if (i::FLAG_always_opt || !i::FLAG_lazy) return;
+ if (i::FLAG_always_opt || !i::FLAG_lazy ||
+ (FLAG_ignition && FLAG_ignition_eager)) {
+ return;
+ }
CcTest::InitializeVM();
v8::HandleScope scope(CcTest::isolate());
v8::Local<v8::Context> context = CcTest::isolate()->GetCurrentContext();
@@ -349,7 +352,8 @@ TEST(FeedbackVectorUnaffectedByScopeChanges) {
->Get(context, v8_str("morphing_call"))
.ToLocalChecked())));
- // Not compiled, and so no feedback vector allocated yet.
+ // If we are compiling lazily then it should not be compiled, and so no
+ // feedback vector allocated yet.
CHECK(!f->shared()->is_compiled());
CHECK(f->shared()->feedback_vector()->is_empty());
« no previous file with comments | « test/cctest/test-api.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698