Chromium Code Reviews

Unified Diff: src/compiler.cc

Issue 1811553003: [Interpreter] Make ignition compiler eagerly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 32120df9e304e31a6115dc507180a9ccd12248de..2861f1ed3f300d14c157b8e26118af3fcaca2ec3 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -1413,6 +1413,9 @@ static Handle<SharedFunctionInfo> CompileToplevel(CompilationInfo* info) {
// Consider parsing eagerly when targeting the code cache.
parse_allow_lazy &= !(FLAG_serialize_eager && info->will_serialize());
+ // Consider compiling eagerly when compiling bytecode for Ignition.
Michael Starzinger 2016/03/17 18:58:51 nit: s/compiling/parsing/
rmcilroy 2016/03/21 15:21:55 Done.
+ parse_allow_lazy &= !(FLAG_ignition && !isolate->serializer_enabled());
+
parse_info->set_allow_lazy_parsing(parse_allow_lazy);
if (!parse_allow_lazy &&
(options == ScriptCompiler::kProduceParserCache ||
@@ -1776,6 +1779,9 @@ Handle<SharedFunctionInfo> Compiler::GetSharedFunctionInfo(
// Consider compiling eagerly when targeting the code cache.
lazy &= !(FLAG_serialize_eager && info.will_serialize());
+ // Consider compiling eagerly when compiling bytecode for Ignition.
+ lazy &= !(FLAG_ignition && !isolate->serializer_enabled());
+
// Generate code
TimerEventScope<TimerEventCompileCode> timer(isolate);
TRACE_EVENT0("v8", "V8.CompileCode");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine