Source/modules/device_orientation/DeviceOrientationEvent.h - Issue 181153003: Make Event RefCountedGarbageCollected and implement trace() methods to the Event hierarcy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceOrientationEvent.h

Issue 181153003: Make Event RefCountedGarbageCollected and implement trace() methods to the Event hierarcy (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/events/Event.h ('K') | « Source/modules/device_orientation/DeviceMotionEvent.cpp ('k') | Source/modules/device_orientation/DeviceOrientationEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceOrientationEvent.h

diff --git a/Source/modules/device_orientation/DeviceOrientationEvent.h b/Source/modules/device_orientation/DeviceOrientationEvent.h

index 52f251cafce21ed73a69eeb4c557459b00599ba9..243f5c220039e322c1fb41cfb94bc043028e0b2f 100644

--- a/Source/modules/device_orientation/DeviceOrientationEvent.h

+++ b/Source/modules/device_orientation/DeviceOrientationEvent.h

@@ -56,11 +56,13 @@ public:

virtual const AtomicString& interfaceName() const OVERRIDE;

+ virtual void trace(Visitor*) OVERRIDE;

private:

DeviceOrientationEvent();

DeviceOrientationEvent(const AtomicString& eventType, DeviceOrientationData*);

- RefPtrWillBePersistent<DeviceOrientationData> m_orientation;

+ RefPtrWillBeMember<DeviceOrientationData> m_orientation;

};

DEFINE_TYPE_CASTS(DeviceOrientationEvent, Event, event, event->interfaceName() == EventNames::DeviceOrientationEvent, event.interfaceName() == EventNames::DeviceOrientationEvent);