Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (C) 2010 Apple Inc. All rights reserved. | 2 * Copyright (C) 2010 Apple Inc. All rights reserved. |
| 3 * | 3 * |
| 4 * Redistribution and use in source and binary forms, with or without | 4 * Redistribution and use in source and binary forms, with or without |
| 5 * modification, are permitted provided that the following conditions | 5 * modification, are permitted provided that the following conditions |
| 6 * are met: | 6 * are met: |
| 7 * 1. Redistributions of source code must retain the above copyright | 7 * 1. Redistributions of source code must retain the above copyright |
| 8 * notice, this list of conditions and the following disclaimer. | 8 * notice, this list of conditions and the following disclaimer. |
| 9 * 2. Redistributions in binary form must reproduce the above copyright | 9 * 2. Redistributions in binary form must reproduce the above copyright |
| 10 * notice, this list of conditions and the following disclaimer in the | 10 * notice, this list of conditions and the following disclaimer in the |
| (...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 51 | 51 |
| 52 DeviceMotionData* deviceMotionData() const { return m_deviceMotionData.get() ; } | 52 DeviceMotionData* deviceMotionData() const { return m_deviceMotionData.get() ; } |
| 53 | 53 |
| 54 DeviceAcceleration* acceleration(); | 54 DeviceAcceleration* acceleration(); |
| 55 DeviceAcceleration* accelerationIncludingGravity(); | 55 DeviceAcceleration* accelerationIncludingGravity(); |
| 56 DeviceRotationRate* rotationRate(); | 56 DeviceRotationRate* rotationRate(); |
| 57 double interval(bool& isNull) const; | 57 double interval(bool& isNull) const; |
| 58 | 58 |
| 59 virtual const AtomicString& interfaceName() const OVERRIDE; | 59 virtual const AtomicString& interfaceName() const OVERRIDE; |
| 60 | 60 |
| 61 virtual void trace(Visitor*) OVERRIDE; | |
| 62 | |
| 61 private: | 63 private: |
| 62 DeviceMotionEvent(); | 64 DeviceMotionEvent(); |
| 63 DeviceMotionEvent(const AtomicString& eventType, DeviceMotionData*); | 65 DeviceMotionEvent(const AtomicString& eventType, DeviceMotionData*); |
| 64 | 66 |
| 65 RefPtrWillBePersistent<DeviceMotionData> m_deviceMotionData; | 67 RefPtrWillBeMember<DeviceMotionData> m_deviceMotionData; |
|
tkent
2014/02/26 08:14:03
I have a concern about changes like this.
After t
haraken
2014/02/26 08:18:30
Good point. The concern is valid. However, we cann
| |
| 66 | 68 RefPtrWillBeMember<DeviceAcceleration> m_acceleration; |
| 67 RefPtrWillBePersistent<DeviceAcceleration> m_acceleration; | 69 RefPtrWillBeMember<DeviceAcceleration> m_accelerationIncludingGravity; |
| 68 RefPtrWillBePersistent<DeviceAcceleration> m_accelerationIncludingGravity; | 70 RefPtrWillBeMember<DeviceRotationRate> m_rotationRate; |
| 69 RefPtrWillBePersistent<DeviceRotationRate> m_rotationRate; | |
| 70 }; | 71 }; |
| 71 | 72 |
| 72 DEFINE_TYPE_CASTS(DeviceMotionEvent, Event, event, event->interfaceName() == Eve ntNames::DeviceMotionEvent, event.interfaceName() == EventNames::DeviceMotionEve nt); | 73 DEFINE_TYPE_CASTS(DeviceMotionEvent, Event, event, event->interfaceName() == Eve ntNames::DeviceMotionEvent, event.interfaceName() == EventNames::DeviceMotionEve nt); |
| 73 | 74 |
| 74 } // namespace WebCore | 75 } // namespace WebCore |
| 75 | 76 |
| 76 #endif // DeviceMotionEvent_h | 77 #endif // DeviceMotionEvent_h |
| OLD | NEW |