Make writes consistent across socket and file synchronous/asynchronus writes in terms of truncation…

sdk/lib/io/common.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart.io;
 
 // Constants used when working with native ports.
 // These must match the constants in runtime/bin/dartutils.h class CObject.
 const int _SUCCESS_RESPONSE = 0;
 const int _ILLEGAL_ARGUMENT_RESPONSE = 1;
@@ skipping 79 matching lines @@
 
 
 // Object for holding a buffer and an offset.
 class _BufferAndStart {
   _BufferAndStart(List this.buffer, int this.start);
   List buffer;
   int start;
 }
 
 // Ensure that the input List can be serialized through a native port.
-// Only builtin Lists can be serialized through. If user-defined Lists
-// get here, the contents is copied to a Uint8List. This has the added
+// Only Int8List and Uint8List Lists are serialized directly.
+// All other lists are first copied into a Uint8List. This has the added
 // benefit that it is faster to access from the C code as well.
-_BufferAndStart _ensureFastAndSerializableData(
+_BufferAndStart _ensureFastAndSerializableByteData(
     List buffer, int start, int end) {
-  if (buffer is Uint8List ||
-      buffer is Int8List ||
-      buffer is Uint16List ||
-      buffer is Int16List ||
-      buffer is Uint32List ||
-      buffer is Int32List ||
-      buffer is Uint64List ||
-      buffer is Int64List ||
-      buffer is ByteData ||
-      buffer is Float32List ||
-      buffer is Float64List ||
-      _BufferUtils._isBuiltinList(buffer)) {
+  if (buffer is Uint8List || buffer is Int8List) {
     return new _BufferAndStart(buffer, start);
   }
   int length = end - start;
-  var newBuffer = new Uint8List(length);
-  int j = start;
-  for (int i = 0; i < length; i++) {
-    int value = buffer[j];
-    if (value is! int) {
-      throw new ArgumentError("List element is not an integer at index $j");
-    }
-    newBuffer[i] = value;
-    j++;
-  }
-  return new _BufferAndStart(newBuffer, 0);
-}
-
-
-_BufferAndStart _ensureFastAndSerializableByteData(
-    List buffer, int start, int end) {
-  if (buffer is Uint8List) {
-    return new _BufferAndStart(buffer, start);
-  }
-  int length = end - start;
   var newBuffer = new Uint8List(length);
   int j = start;
   for (int i = 0; i < length; i++) {
     int value = buffer[j];
     if (value is! int ||
         value < 0 || 255 < value) {

[Ivan Posva, 2013/06/28 23:10:13]

I was under the impression that we agree on this working at all times:

var l = rnd.nextBool() ? new Uint8List(1) : new List(1);
l[0] = 260;
file.writeFromSync(l, 0, 1);

[siva, 2013/06/29 18:19:01]

I have changed this to truncate instead of throwing an exception.

I have commented out the two testOutofRange tests in
tests/standalone/io/file_typed_data_test.dart
tests/standalone/io/web_socket_typed_data_test.dart
which were testing for this condition


On 2013/06/28 23:10:13, Ivan Posva wrote:

       throw new ArgumentError(
           "List element is not a byte value (value $value at index $j)");
     }
     newBuffer[i] = value;
     j++;
   }
   return new _BufferAndStart(newBuffer, 0);
 }
 
 
-// TODO(ager): The only reason for the class here is that
-// we cannot patch a top-level function.
-class _BufferUtils {
-  // Check if a List is a builtin VM List type. Returns true
-  // if the List is a builtin VM List type and false if it is
-  // a user defined List type.
-  external static bool _isBuiltinList(List buffer);
-}
-
 class _IOCrypto {
   external static Uint8List getRandomBytes(int count);
 }