Make writes consistent across socket and file synchronous/asynchronus writes in terms of truncation…

runtime/bin/file.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/file.h"
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
 #include "bin/io_buffer.h"
 #include "bin/thread.h"
@@ skipping 236 matching lines @@
   }
   delete[] buffer;
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(File_WriteFrom)(Dart_NativeArguments args) {
   Dart_EnterScope();
   File* file = GetFilePointer(Dart_GetNativeArgument(args, 0));
   ASSERT(file != NULL);
+
   Dart_Handle buffer_obj = Dart_GetNativeArgument(args, 1);
-  ASSERT(Dart_IsList(buffer_obj));
+
   // Offset and length arguments are checked in Dart code to be
   // integers and have the property that (offset + length) <=
   // list.length. Therefore, it is safe to extract their value as
   // intptr_t.
   intptr_t start =
       DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 2));
   intptr_t end =
       DartUtils::GetIntptrValue(Dart_GetNativeArgument(args, 3));
+
+  // The buffer object passed in has to be an Int8List or Uint8List object.
+  // Acquire a direct pointer to the data area of the buffer object.
+  Dart_TypedData_Type type;
   intptr_t length = end - start;
   intptr_t buffer_len = 0;
-  Dart_Handle result = Dart_ListLength(buffer_obj, &buffer_len);
+  void* buffer = NULL;
+  Dart_Handle result =
+      Dart_TypedDataAcquireData(buffer_obj, &type, &buffer, &buffer_len);
   if (Dart_IsError(result)) Dart_PropagateError(result);
+
+  ASSERT(type == Dart_TypedData_kUint8 || type == Dart_TypedData_kInt8);
   ASSERT(end <= buffer_len);
-  uint8_t* buffer = new uint8_t[length];
-  result = Dart_ListGetAsBytes(buffer_obj, start, buffer, length);
-  if (Dart_IsError(result)) {
-    delete[] buffer;
-    Dart_PropagateError(result);
-  }
+  ASSERT(buffer != NULL);
+
+  // Write the data out into the file.
   int64_t bytes_written = file->Write(reinterpret_cast<void*>(buffer), length);
+
+  // Release the direct pointer acquired above.
+  result = Dart_TypedDataReleaseData(buffer_obj);
+  if (Dart_IsError(result)) Dart_PropagateError(result);
+
   if (bytes_written != length) {
     Dart_Handle err = DartUtils::NewDartOSError();
     if (Dart_IsError(err)) Dart_PropagateError(err);
     Dart_SetReturnValue(args, err);
   }
-  delete[] buffer;
   Dart_ExitScope();
 }
 
 
 void FUNCTION_NAME(File_Position)(Dart_NativeArguments args) {
   Dart_EnterScope();
   File* file = GetFilePointer(Dart_GetNativeArgument(args, 0));
   ASSERT(file != NULL);
   intptr_t return_value = file->Position();
   if (return_value >= 0) {
@@ skipping 1025 matching lines @@
   if (service_port != ILLEGAL_PORT) {
     // Return a send port for the service port.
     Dart_Handle send_port = Dart_NewSendPort(service_port);
     Dart_SetReturnValue(args, send_port);
   }
   Dart_ExitScope();
 }
 
 }  // namespace bin
 }  // namespace dart