Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1811483004: Add back SkAutoTDelete::detach() for Android temporarily. (Closed)

Created:
4 years, 9 months ago by mtklein_C
Modified:
4 years, 9 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M include/private/SkTemplates.h View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811483004/1
4 years, 9 months ago (2016-03-17 00:15:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/cc864c336d19e3223f603af5f711a00ad721f647
4 years, 9 months ago (2016-03-17 00:33:59 UTC) #6
scroggo
lgtm https://codereview.chromium.org/1811483004/diff/1/include/private/SkTemplates.h File include/private/SkTemplates.h (right): https://codereview.chromium.org/1811483004/diff/1/include/private/SkTemplates.h#newcode102 include/private/SkTemplates.h:102: // Need to update graphics/BitmapRegionDecoder.cpp. Looks like we ...
4 years, 9 months ago (2016-03-17 12:37:48 UTC) #8
mtklein
> Looks like we also need to update Shader.cpp That's an SkAutoTUnref, right?
4 years, 9 months ago (2016-03-17 12:39:13 UTC) #9
scroggo
4 years, 9 months ago (2016-03-17 13:08:27 UTC) #10
Message was sent while issue was closed.
On 2016/03/17 12:39:13, mtklein wrote:
> > Looks like we also need to update Shader.cpp
> 
> That's an SkAutoTUnref, right?

D'oh. Yes. And I see you fixed with crrev.com/1812843002

Powered by Google App Engine
This is Rietveld 408576698