Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1811483002: jumplist_win.h: Speculative Clang style plugin fix (Closed)

Created:
4 years, 9 months ago by hans
Modified:
4 years, 9 months ago
Reviewers:
tzik
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

jumplist_win.h: Speculative Clang style plugin fix The build was failing with: ..\..\chrome/browser/jumplist_win.h(61,3): error: [chromium-style] Complex class/struct needs an explicit out-of-line constructor. struct JumpListData { ^ BUG=82385 TBR=tzik Committed: https://crrev.com/331970e5e418bbf29882462c9ebb867c673479bb Cr-Commit-Position: refs/heads/master@{#381441}

Patch Set 1 #

Patch Set 2 : Actually add the declarations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/jumplist_win.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/jumplist_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811483002/20001
4 years, 9 months ago (2016-03-16 12:15:19 UTC) #4
tzik
lgtm
4 years, 9 months ago (2016-03-16 12:20:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 13:14:58 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 13:16:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/331970e5e418bbf29882462c9ebb867c673479bb
Cr-Commit-Position: refs/heads/master@{#381441}

Powered by Google App Engine
This is Rietveld 408576698