Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 1811473002: Emit write barrier for old space constants. (Closed)

Created:
4 years, 9 months ago by Hannes Payer (out of office)
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Emit write barrier for old space constants. Tenured objects allocated on black pages require write barriers. BUG=chromium:594958 LOG=n Committed: https://crrev.com/ddb9707db95a98a63db223c6c3c4e860cb30e250 Cr-Commit-Position: refs/heads/master@{#34818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/crankshaft/hydrogen-instructions.h View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Hannes Payer (out of office)
4 years, 9 months ago (2016-03-16 11:35:32 UTC) #3
Michael Lippautz
lgtm -- maybe add to the description that constant types do not imply that objects ...
4 years, 9 months ago (2016-03-16 12:00:45 UTC) #6
Hannes Payer (out of office)
StoringValueNeedsWriteBarrier takes care of immortal immovables.
4 years, 9 months ago (2016-03-16 12:08:33 UTC) #7
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-16 14:37:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811473002/1
4 years, 9 months ago (2016-03-16 14:37:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 14:39:42 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 14:41:18 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddb9707db95a98a63db223c6c3c4e860cb30e250
Cr-Commit-Position: refs/heads/master@{#34818}

Powered by Google App Engine
This is Rietveld 408576698