SubtreeShouldBeSkipped uses information from property trees

cc/trees/layer_tree_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_impl.h"
 
 #include "cc/layers/heads_up_display_layer_impl.h"
 #include "cc/layers/layer.h"
 #include "cc/layers/solid_color_scrollbar_layer_impl.h"
 #include "cc/test/fake_impl_task_runner_provider.h"
@@ skipping 2338 matching lines @@
   input.end.type = SELECTION_BOUND_RIGHT;
   input.end.edge_top = gfx::Point(50, 10);
   input.end.edge_bottom = gfx::Point(50, 30);
   input.end.layer_id = grand_child_id;
 
   host_impl().active_tree()->RegisterSelection(input);
 
   ViewportSelection output;
   host_impl().active_tree()->GetViewportSelection(&output);
 
-  // edge_bottom and edge_top aren't allowed to have NaNs, so the selection
-  // should be empty.
-  EXPECT_EQ(ViewportSelectionBound(), output.start);
-  EXPECT_EQ(ViewportSelectionBound(), output.end);
+  ViewportSelectionBound expected_start;
+  ViewportSelectionBound expected_end;
+
+  expected_start.type = SELECTION_BOUND_LEFT;
+  expected_start.edge_top = gfx::PointF(10, 10);
+  expected_start.edge_bottom = gfx::PointF(10, 20);
+  expected_start.visible = true;
+
+  expected_end.type = SELECTION_BOUND_RIGHT;
+  expected_end.edge_top = gfx::PointF(50, 10);
+  expected_end.edge_bottom = gfx::PointF(50, 30);
+  expected_end.visible = true;
+
+  EXPECT_EQ(expected_start, output.start);
+  EXPECT_EQ(expected_end, output.end);

[ajuma, 2016/03/24 15:11:59]

I think this might be another case where we have a layer that's winding up in
the RSLL but not getting draw properties computed.

 }
 
 TEST_F(LayerTreeImplTest, NumLayersTestOne) {
   EXPECT_EQ(0u, host_impl().active_tree()->NumLayers());
   scoped_ptr<LayerImpl> root = LayerImpl::Create(host_impl().active_tree(), 1);
   EXPECT_EQ(1u, host_impl().active_tree()->NumLayers());
 }
 
 TEST_F(LayerTreeImplTest, NumLayersSmallTree) {
   EXPECT_EQ(0u, host_impl().active_tree()->NumLayers());
   scoped_ptr<LayerImpl> root = LayerImpl::Create(host_impl().active_tree(), 1);
   root->AddChild(LayerImpl::Create(host_impl().active_tree(), 2));
   root->AddChild(LayerImpl::Create(host_impl().active_tree(), 3));
   root->child_at(1)->AddChild(LayerImpl::Create(host_impl().active_tree(), 4));
   EXPECT_EQ(4u, host_impl().active_tree()->NumLayers());
 }
 
 TEST_F(LayerTreeImplTest, DeviceScaleFactorNeedsDrawPropertiesUpdate) {
   host_impl().active_tree()->SetDeviceScaleFactor(1.f);
   host_impl().active_tree()->UpdateDrawProperties(false);
   EXPECT_FALSE(host_impl().active_tree()->needs_update_draw_properties());
   host_impl().active_tree()->SetDeviceScaleFactor(2.f);
   EXPECT_TRUE(host_impl().active_tree()->needs_update_draw_properties());
 }
 
 }  // namespace
 }  // namespace cc