Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc

Issue 1811413002: [Extensions] Update generated code to support move operations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile fix Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
diff --git a/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc b/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
index f12df3aa273a42e39979488df79f8a6012332839..e5051949ed1ce879d9861a81c68436eede50d81e 100644
--- a/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
+++ b/chrome/browser/extensions/api/developer_private/inspectable_views_finder.cc
@@ -38,45 +38,44 @@ InspectableViewsFinder::View InspectableViewsFinder::ConstructView(
bool incognito,
bool is_iframe,
ViewType type) {
- linked_ptr<api::developer_private::ExtensionView> view(
- new api::developer_private::ExtensionView());
- view->url = url.spec();
- view->render_process_id = render_process_id;
+ api::developer_private::ExtensionView view;
+ view.url = url.spec();
+ view.render_process_id = render_process_id;
// NOTE(devlin): This is called "render_view_id" in the api for legacy
// reasons, but it's not a high priority to change.
- view->render_view_id = render_frame_id;
- view->incognito = incognito;
- view->is_iframe = is_iframe;
+ view.render_view_id = render_frame_id;
+ view.incognito = incognito;
+ view.is_iframe = is_iframe;
switch (type) {
case VIEW_TYPE_APP_WINDOW:
- view->type = api::developer_private::VIEW_TYPE_APP_WINDOW;
+ view.type = api::developer_private::VIEW_TYPE_APP_WINDOW;
break;
case VIEW_TYPE_BACKGROUND_CONTENTS:
- view->type = api::developer_private::VIEW_TYPE_BACKGROUND_CONTENTS;
+ view.type = api::developer_private::VIEW_TYPE_BACKGROUND_CONTENTS;
break;
case VIEW_TYPE_COMPONENT:
- view->type = api::developer_private::VIEW_TYPE_COMPONENT;
+ view.type = api::developer_private::VIEW_TYPE_COMPONENT;
break;
case VIEW_TYPE_EXTENSION_BACKGROUND_PAGE:
- view->type = api::developer_private::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE;
+ view.type = api::developer_private::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE;
break;
case VIEW_TYPE_EXTENSION_DIALOG:
- view->type = api::developer_private::VIEW_TYPE_EXTENSION_DIALOG;
+ view.type = api::developer_private::VIEW_TYPE_EXTENSION_DIALOG;
break;
case VIEW_TYPE_EXTENSION_GUEST:
- view->type = api::developer_private::VIEW_TYPE_EXTENSION_GUEST;
+ view.type = api::developer_private::VIEW_TYPE_EXTENSION_GUEST;
break;
case VIEW_TYPE_EXTENSION_POPUP:
- view->type = api::developer_private::VIEW_TYPE_EXTENSION_POPUP;
+ view.type = api::developer_private::VIEW_TYPE_EXTENSION_POPUP;
break;
case VIEW_TYPE_LAUNCHER_PAGE:
- view->type = api::developer_private::VIEW_TYPE_LAUNCHER_PAGE;
+ view.type = api::developer_private::VIEW_TYPE_LAUNCHER_PAGE;
break;
case VIEW_TYPE_PANEL:
- view->type = api::developer_private::VIEW_TYPE_PANEL;
+ view.type = api::developer_private::VIEW_TYPE_PANEL;
break;
case VIEW_TYPE_TAB_CONTENTS:
- view->type = api::developer_private::VIEW_TYPE_TAB_CONTENTS;
+ view.type = api::developer_private::VIEW_TYPE_TAB_CONTENTS;
break;
default:
NOTREACHED();

Powered by Google App Engine
This is Rietveld 408576698