Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_apitest.cc

Issue 1811413002: [Extensions] Update generated code to support move operations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile fix Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/developer_private/developer_private_apitest.cc
diff --git a/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc b/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc
index ec28633011d594b6c61647da72049c0eab4e96d4..40bb0eba3e5bcff337858797d8e67952f8a5827e 100644
--- a/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc
+++ b/chrome/browser/extensions/api/developer_private/developer_private_apitest.cc
@@ -57,10 +57,10 @@ IN_PROC_BROWSER_TEST_F(DeveloperPrivateApiTest, InspectAppWindowView) {
// There should be two inspectable views - the background page and the app
// window. Find the app window.
ASSERT_EQ(2u, info->views.size());
- api::developer_private::ExtensionView* window_view = nullptr;
+ const api::developer_private::ExtensionView* window_view = nullptr;
for (const auto& view : info->views) {
- if (view->type == api::developer_private::VIEW_TYPE_APP_WINDOW) {
- window_view = view.get();
+ if (view.type == api::developer_private::VIEW_TYPE_APP_WINDOW) {
+ window_view = &view;
break;
}
}
@@ -110,21 +110,20 @@ IN_PROC_BROWSER_TEST_F(DeveloperPrivateApiTest, InspectEmbeddedOptionsPage) {
// The embedded options page should show up.
ASSERT_EQ(1u, info->views.size());
- api::developer_private::ExtensionView* view = info->views[0].get();
- ASSERT_TRUE(view);
- ASSERT_EQ(api::developer_private::VIEW_TYPE_EXTENSION_GUEST, view->type);
+ const api::developer_private::ExtensionView& view = info->views[0];
+ ASSERT_EQ(api::developer_private::VIEW_TYPE_EXTENSION_GUEST, view.type);
// Inspect the embedded options page.
function = new api::DeveloperPrivateOpenDevToolsFunction();
extension_function_test_utils::RunFunction(
function.get(),
base::StringPrintf("[{\"renderViewId\": %d, \"renderProcessId\": %d}]",
- view->render_view_id, view->render_process_id),
+ view.render_view_id, view.render_process_id),
browser(), extension_function_test_utils::NONE);
// Verify that dev tools opened.
content::RenderFrameHost* rfh = content::RenderFrameHost::FromID(
- view->render_process_id, view->render_view_id);
+ view.render_process_id, view.render_view_id);
ASSERT_TRUE(rfh);
content::WebContents* wc = content::WebContents::FromRenderFrameHost(rfh);
ASSERT_TRUE(wc);

Powered by Google App Engine
This is Rietveld 408576698