[Extensions] Update generated code to support move operations

tools/json_schema_compiler/util.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef TOOLS_JSON_SCHEMA_COMPILER_UTIL_H__
 #define TOOLS_JSON_SCHEMA_COMPILER_UTIL_H__
 
 #include <string>
 #include <vector>
 
@@ skipping 39 matching lines @@
   const base::DictionaryValue* dict = nullptr;
   if (!from.GetAsDictionary(&dict))
     return false;
   scoped_ptr<T> obj(new T());
   if (!T::Populate(*dict, obj.get()))
     return false;
   *out = linked_ptr<T>(obj.release());
   return true;
 }
 
+// This template is used for types generated by tools/json_schema_compiler.
+template <class T>
+bool PopulateItem(const base::Value& from, T* out) {
+  const base::DictionaryValue* dict = nullptr;
+  if (!from.GetAsDictionary(&dict))
+    return false;
+  T obj;
+  if (!T::Populate(*dict, &obj))
+    return false;
+  *out = std::move(obj);
+  return true;
+}
+
 // This template is used for types generated by tools/json_schema_compiler with
 // error generation enabled.
 template <class T>
 bool PopulateItem(const base::Value& from,
                   linked_ptr<T>* out,
                   base::string16* error) {
   const base::DictionaryValue* dict = nullptr;
   if (!from.GetAsDictionary(&dict))
     return false;
   scoped_ptr<T> obj(new T());
   if (!T::Populate(*dict, obj.get(), error))
     return false;
   *out = linked_ptr<T>(obj.release());
   return true;
 }
 
 // Populates |out| with |list|. Returns false if there is no list at the
 // specified key or if the list has anything other than |T|.
 template <class T>
 bool PopulateArrayFromList(const base::ListValue& list, std::vector<T>* out) {
   out->clear();
   T item;
   for (const base::Value* value : list) {
     if (!PopulateItem(*value, &item))
       return false;
-    out->push_back(item);
+    // T might not be movable, but in that case it should be copyable, and this
+    // will still work.
+    out->push_back(std::move(item));
   }
 
   return true;
 }
 
 // Populates |out| with |list|. Returns false and sets |error| if there is no
 // list at the specified key or if the list has anything other than |T|.
 template <class T>
 bool PopulateArrayFromList(const base::ListValue& list,
                            std::vector<T>* out,
@@ skipping 45 matching lines @@
 void AddItemToList(const linked_ptr<base::Value>& from, base::ListValue* out);
 void AddItemToList(const linked_ptr<base::DictionaryValue>& from,
                    base::ListValue* out);
 
 // This template is used for types generated by tools/json_schema_compiler.
 template <class T>
 void AddItemToList(const linked_ptr<T>& from, base::ListValue* out) {
   out->Append(from->ToValue().release());
 }
 
+// This template is used for types generated by tools/json_schema_compiler.
+template <class T>
+void AddItemToList(const T& from, base::ListValue* out) {
+  out->Append(from.ToValue().release());

[dcheng, 2016/03/22 17:42:34]

No .release().

[Devlin, 2016/03/22 17:58:40]

Done.

+}
+
 // Set |out| to the the contents of |from|. Requires PopulateItem to be
 // implemented for |T|.
 template <class T>
 void PopulateListFromArray(const std::vector<T>& from, base::ListValue* out) {
   out->Clear();
   for (const auto& item : from)
     AddItemToList(item, out);
 }
 
 // Set |out| to the the contents of |from| if |from| is not null. Requires
@@ skipping 19 matching lines @@
     return CreateValueFromArray(*from);
   return scoped_ptr<base::Value>();
 }
 
 std::string ValueTypeToString(base::Value::Type type);
 
 }  // namespace util
 }  // namespace json_schema_compiler
 
 #endif  // TOOLS_JSON_SCHEMA_COMPILER_UTIL_H__