adb_gdb: Detect TARGET_ARCH from symbols_dir rather than device

adb_gdb: Detect TARGET_ARCH from symbols_dir rather than device

This fixes arch detection when 32-bit Chrome is run on a 64-bit device

BUG=596088
Committed: https://crrev.com/2e65b753af3feb69f69c35335db12526ff8d7220
Cr-Commit-Position: refs/heads/master@{#382319}

[agrieve, 2016-03-18 16:27:07]

Description was changed from

==========
adb_gdb: Detect TARGET_ARCH from symbols_dir rather than device

This fixes arch detection when 32-bit Chrome is run on a 64-bit device

BUG=596088
==========

to

==========
adb_gdb: Detect TARGET_ARCH from symbols_dir rather than device

This fixes arch detection when 32-bit Chrome is run on a 64-bit device

BUG=596088
==========

[agrieve, 2016-03-18 16:27:07]

agrieve@chromium.org changed reviewers:
+ yfriedman@chromium.org

[agrieve, 2016-03-18 17:14:32]

On 2016/03/18 16:27:07, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:yfriedman@chromium.org

[Yaron, 2016-03-18 17:19:17]

https://codereview.chromium.org/1811363002/diff/1/build/android/adb_gdb
File build/android/adb_gdb (right):

https://codereview.chromium.org/1811363002/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:382: panic "Could not find any symbols under $SYMBOL_DIR"
Does this break the case of downloading a symbols.zip and gdb'ing official
build?

[agrieve, 2016-03-18 18:15:29]

https://codereview.chromium.org/1811363002/diff/1/build/android/adb_gdb
File build/android/adb_gdb (right):

https://codereview.chromium.org/1811363002/diff/1/build/android/adb_gdb#newco...
build/android/adb_gdb:382: panic "Could not find any symbols under $SYMBOL_DIR"
On 2016/03/18 17:19:17, Yaron wrote:
> Does this break the case of downloading a symbols.zip and gdb'ing official
> build?

I don't think so. It's just checking that at least 1 .so file exists in the
user-specified symbols directory.

[Yaron, 2016-03-18 18:19:35]

On 2016/03/18 18:15:29, agrieve wrote:
> https://codereview.chromium.org/1811363002/diff/1/build/android/adb_gdb
> File build/android/adb_gdb (right):
> 
>
https://codereview.chromium.org/1811363002/diff/1/build/android/adb_gdb#newco...
> build/android/adb_gdb:382: panic "Could not find any symbols under
$SYMBOL_DIR"
> On 2016/03/18 17:19:17, Yaron wrote:
> > Does this break the case of downloading a symbols.zip and gdb'ing official
> > build?
> 
> I don't think so. It's just checking that at least 1 .so file exists in the
> user-specified symbols directory.

But I believe the script can work without extracting symbols.zip (i.e. it loads
directly from it). So you're saying you'd have to have built *something* for it
to work? It's probably not a big deal but it bothers me a bit that your
unrelated output dir is affecting how this behaves

[agrieve, 2016-03-18 20:27:50]

On 2016/03/18 18:19:35, Yaron wrote:
> On 2016/03/18 18:15:29, agrieve wrote:
> > https://codereview.chromium.org/1811363002/diff/1/build/android/adb_gdb
> > File build/android/adb_gdb (right):
> > 
> >
>
https://codereview.chromium.org/1811363002/diff/1/build/android/adb_gdb#newco...
> > build/android/adb_gdb:382: panic "Could not find any symbols under
> $SYMBOL_DIR"
> > On 2016/03/18 17:19:17, Yaron wrote:
> > > Does this break the case of downloading a symbols.zip and gdb'ing official
> > > build?
> > 
> > I don't think so. It's just checking that at least 1 .so file exists in the
> > user-specified symbols directory.
> 
> But I believe the script can work without extracting symbols.zip (i.e. it
loads
> directly from it). So you're saying you'd have to have built *something* for
it
> to work? It's probably not a big deal but it bothers me a bit that your
> unrelated output dir is affecting how this behaves

Doesn't look like the script ever supported using --symbol-dir=syms.zip. Only a
directory.

[Yaron, 2016-03-18 21:34:46]

lgtm - thanks for the explanation. I must've confused this with
./third_party/android_platform/development/scripts/stack

[agrieve, 2016-03-21 16:48:56]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-03-21 16:49:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811363002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811363002/20001

[commit-bot: I haz the power, 2016-03-21 17:36:23]

Description was changed from

==========
adb_gdb: Detect TARGET_ARCH from symbols_dir rather than device

This fixes arch detection when 32-bit Chrome is run on a 64-bit device

BUG=596088
==========

to

==========
adb_gdb: Detect TARGET_ARCH from symbols_dir rather than device

This fixes arch detection when 32-bit Chrome is run on a 64-bit device

BUG=596088
==========

[commit-bot: I haz the power, 2016-03-21 17:36:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-21 17:39:15]

Description was changed from

==========
adb_gdb: Detect TARGET_ARCH from symbols_dir rather than device

This fixes arch detection when 32-bit Chrome is run on a 64-bit device

BUG=596088
==========

to

==========
adb_gdb: Detect TARGET_ARCH from symbols_dir rather than device

This fixes arch detection when 32-bit Chrome is run on a 64-bit device

BUG=596088

Committed: https://crrev.com/2e65b753af3feb69f69c35335db12526ff8d7220
Cr-Commit-Position: refs/heads/master@{#382319}
==========

[commit-bot: I haz the power, 2016-03-21 17:39:17]

Patchset 2 (id:??) landed as
https://crrev.com/2e65b753af3feb69f69c35335db12526ff8d7220
Cr-Commit-Position: refs/heads/master@{#382319}