Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1811353002:
Disable smoothness.tough_animation_cases on low-end win bots (Closed)
DescriptionDisable smoothness.tough_animation_cases on low-end win bots
BUG=595737
Committed: https://crrev.com/9ee2563864c7c680e775da2eb803af70052b7b30
Cr-Commit-Position: refs/heads/master@{#382063}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add full stop #Messages
Total messages: 22 (12 generated)
Description was changed from ========== Disable smoothness.tough_animation_cases on low-end win bots BUG=595737 ========== to ========== Disable smoothness.tough_animation_cases on low-end win bots BUG=595737 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ==========
nednguyen@google.com changed reviewers: + eakuefner@chromium.org, petrcermak@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811353002/1
LGTM with one nit. Thanks, Petr https://codereview.chromium.org/1811353002/diff/1/tools/perf/benchmarks/smoot... File tools/perf/benchmarks/smoothness.py (right): https://codereview.chromium.org/1811353002/diff/1/tools/perf/benchmarks/smoot... tools/perf/benchmarks/smoothness.py:145: # This test is flaky on low-end windows machine nit: You're missing a full stop after this comment.
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from petrcermak@chromium.org Link to the patchset: https://codereview.chromium.org/1811353002/#ps20001 (title: "Add full stop")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811353002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) linux_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by petrcermak@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811353002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Disable smoothness.tough_animation_cases on low-end win bots BUG=595737 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq ========== to ========== Disable smoothness.tough_animation_cases on low-end win bots BUG=595737 ==========
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811353002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811353002/20001
Message was sent while issue was closed.
Description was changed from ========== Disable smoothness.tough_animation_cases on low-end win bots BUG=595737 ========== to ========== Disable smoothness.tough_animation_cases on low-end win bots BUG=595737 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Disable smoothness.tough_animation_cases on low-end win bots BUG=595737 ========== to ========== Disable smoothness.tough_animation_cases on low-end win bots BUG=595737 Committed: https://crrev.com/9ee2563864c7c680e775da2eb803af70052b7b30 Cr-Commit-Position: refs/heads/master@{#382063} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/9ee2563864c7c680e775da2eb803af70052b7b30 Cr-Commit-Position: refs/heads/master@{#382063} |
