Move the remaining NTP realted files to c/b/android/ntp subdir.

Move the remaining NTP realted files to c/b/android/ntp subdir.

BUG=596080
Committed: https://crrev.com/ea5c499adf2b5bf93ed158d0d5084fc6ef768c66
Cr-Commit-Position: refs/heads/master@{#382003}

[markusheintz_, 2016-03-18 14:50:44]

Description was changed from

==========
Move the remaining NTP realted files to c/b/android/ntp subdir.

BUG=TODO
==========

to

==========
Move the remaining NTP realted files to c/b/android/ntp subdir.

BUG=TODO
==========

[markusheintz_, 2016-03-18 14:50:44]

markusheintz@chromium.org changed reviewers:
+ bauerb@chromium.org

[markusheintz_, 2016-03-18 14:52:00]

markusheintz@chromium.org changed reviewers:
+ markusheintz@chromium.org

[markusheintz_, 2016-03-18 14:52:01]

Sorry this CL also contains the changes of the other one.

I'll sync and update ASAP the other CL lander. However I already have a
question.

https://codereview.chromium.org/1811333003/diff/1/chrome/browser/android/ntp/...
File chrome/browser/android/ntp/new_tab_page_url_handler.h (left):

https://codereview.chromium.org/1811333003/diff/1/chrome/browser/android/ntp/...
chrome/browser/android/ntp/new_tab_page_url_handler.h:16: 
I guess we want to add a namespace ntp here.

[Bernhard Bauer, 2016-03-18 14:58:49]

https://codereview.chromium.org/1811333003/diff/1/chrome/browser/android/ntp/...
File chrome/browser/android/ntp/OWNERS (right):

https://codereview.chromium.org/1811333003/diff/1/chrome/browser/android/ntp/...
chrome/browser/android/ntp/OWNERS:1: bauerb@chromium.org
We inherit c/b/a/OWNERS, but it might make sense to add newt@ specifically here
as the current Android NTP owner.

https://codereview.chromium.org/1811333003/diff/1/chrome/browser/android/ntp/...
File chrome/browser/android/ntp/new_tab_page_url_handler.h (left):

https://codereview.chromium.org/1811333003/diff/1/chrome/browser/android/ntp/...
chrome/browser/android/ntp/new_tab_page_url_handler.h:16: 
On 2016/03/18 14:52:01, markusheintz_ wrote:
> I guess we want to add a namespace ntp here.

Not necessarily -- the only reason we have a namespace here in the first place
is so that the method below isn't in the global namespace.

[Marc Treib, 2016-03-18 15:04:20]

treib@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2016-03-18 15:04:21]

https://codereview.chromium.org/1811333003/diff/1/chrome/browser/android/ntp/...
File chrome/browser/android/ntp/new_tab_page_url_handler.h (left):

https://codereview.chromium.org/1811333003/diff/1/chrome/browser/android/ntp/...
chrome/browser/android/ntp/new_tab_page_url_handler.h:6: #define
CHROME_BROWSER_ANDROID_NEW_TAB_PAGE_URL_HANDLER_H_
Add _NTP

[markusheintz_, 2016-03-18 15:42:37]

https://codereview.chromium.org/1811333003/diff/1/chrome/browser/android/ntp/...
File chrome/browser/android/ntp/new_tab_page_url_handler.h (left):

https://codereview.chromium.org/1811333003/diff/1/chrome/browser/android/ntp/...
chrome/browser/android/ntp/new_tab_page_url_handler.h:6: #define
CHROME_BROWSER_ANDROID_NEW_TAB_PAGE_URL_HANDLER_H_
On 2016/03/18 15:04:21, Marc Treib wrote:
> Add _NTP

Done.

https://codereview.chromium.org/1811333003/diff/1/chrome/browser/android/ntp/...
chrome/browser/android/ntp/new_tab_page_url_handler.h:16: 
On 2016/03/18 14:58:49, Bernhard Bauer wrote:
> On 2016/03/18 14:52:01, markusheintz_ wrote:
> > I guess we want to add a namespace ntp here.
> 
> Not necessarily -- the only reason we have a namespace here in the first place
> is so that the method below isn't in the global namespace.

Ok then I won't touch it. :-)

[Marc Treib, 2016-03-18 15:44:42]

https://codereview.chromium.org/1811333003/diff/20001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1811333003/diff/20001/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:834: 'browser/android/ntp/ntp_snippets_bridge.cc',
I think here you still have remnants of the previous CL?

[markusheintz_, 2016-03-18 15:46:57]

Description was changed from

==========
Move the remaining NTP realted files to c/b/android/ntp subdir.

BUG=TODO
==========

to

==========
Move the remaining NTP realted files to c/b/android/ntp subdir.

BUG=596080
==========

[markusheintz_, 2016-03-18 16:01:03]

https://codereview.chromium.org/1811333003/diff/20001/chrome/chrome_browser.gypi
File chrome/chrome_browser.gypi (right):

https://codereview.chromium.org/1811333003/diff/20001/chrome/chrome_browser.g...
chrome/chrome_browser.gypi:834: 'browser/android/ntp/ntp_snippets_bridge.cc',
On 2016/03/18 15:44:42, Marc Treib wrote:
> I think here you still have remnants of the previous CL?

Fixed. Thanks

[Bernhard Bauer, 2016-03-18 16:05:58]

lgtm

[Marc Treib, 2016-03-18 16:12:26]

lgtm

[markusheintz_, 2016-03-18 16:47:14]

The CQ bit was checked by markusheintz@chromium.org

[commit-bot: I haz the power, 2016-03-18 16:47:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811333003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811333003/40001

[commit-bot: I haz the power, 2016-03-18 17:27:21]

Description was changed from

==========
Move the remaining NTP realted files to c/b/android/ntp subdir.

BUG=596080
==========

to

==========
Move the remaining NTP realted files to c/b/android/ntp subdir.

BUG=596080
==========

[commit-bot: I haz the power, 2016-03-18 17:27:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-18 17:28:27]

Description was changed from

==========
Move the remaining NTP realted files to c/b/android/ntp subdir.

BUG=596080
==========

to

==========
Move the remaining NTP realted files to c/b/android/ntp subdir.

BUG=596080

Committed: https://crrev.com/ea5c499adf2b5bf93ed158d0d5084fc6ef768c66
Cr-Commit-Position: refs/heads/master@{#382003}
==========

[commit-bot: I haz the power, 2016-03-18 17:28:28]

Patchset 3 (id:??) landed as
https://crrev.com/ea5c499adf2b5bf93ed158d0d5084fc6ef768c66
Cr-Commit-Position: refs/heads/master@{#382003}