Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: src/interpreter/interpreter.cc

Issue 1811323002: [Interpreter] Add ignition compile trace events. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/log.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/interpreter.h" 5 #include "src/interpreter/interpreter.h"
6 6
7 #include "src/ast/prettyprinter.h" 7 #include "src/ast/prettyprinter.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/compiler.h" 9 #include "src/compiler.h"
10 #include "src/factory.h" 10 #include "src/factory.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 } 59 }
60 60
61 // static 61 // static
62 int Interpreter::InterruptBudget() { 62 int Interpreter::InterruptBudget() {
63 // TODO(ignition): Tune code size multiplier. 63 // TODO(ignition): Tune code size multiplier.
64 const int kCodeSizeMultiplier = 32; 64 const int kCodeSizeMultiplier = 32;
65 return FLAG_interrupt_budget * kCodeSizeMultiplier; 65 return FLAG_interrupt_budget * kCodeSizeMultiplier;
66 } 66 }
67 67
68 bool Interpreter::MakeBytecode(CompilationInfo* info) { 68 bool Interpreter::MakeBytecode(CompilationInfo* info) {
69 TimerEventScope<TimerEventCompileIgnition> timer(info->isolate());
jochen (gone - plz use gerrit) 2016/03/18 12:40:31 why both a timer event scope and a trace event?
rmcilroy 2016/03/18 12:42:44 I was making it the same as FCG - I thought we mig
70 TRACE_EVENT0("v8", "V8.CompileIgnition");
71
69 if (FLAG_print_bytecode || FLAG_print_source || FLAG_print_ast) { 72 if (FLAG_print_bytecode || FLAG_print_source || FLAG_print_ast) {
70 OFStream os(stdout); 73 OFStream os(stdout);
71 base::SmartArrayPointer<char> name = info->GetDebugName(); 74 base::SmartArrayPointer<char> name = info->GetDebugName();
72 os << "[generating bytecode for function: " << info->GetDebugName().get() 75 os << "[generating bytecode for function: " << info->GetDebugName().get()
73 << "]" << std::endl 76 << "]" << std::endl
74 << std::flush; 77 << std::flush;
75 } 78 }
76 79
77 #ifdef DEBUG 80 #ifdef DEBUG
78 if (info->parse_info() && FLAG_print_source) { 81 if (info->parse_info() && FLAG_print_source) {
(...skipping 1841 matching lines...) Expand 10 before | Expand all | Expand 10 after
1920 Node* index = __ LoadRegister(index_reg); 1923 Node* index = __ LoadRegister(index_reg);
1921 Node* one = __ SmiConstant(Smi::FromInt(1)); 1924 Node* one = __ SmiConstant(Smi::FromInt(1));
1922 Node* result = __ SmiAdd(index, one); 1925 Node* result = __ SmiAdd(index, one);
1923 __ SetAccumulator(result); 1926 __ SetAccumulator(result);
1924 __ Dispatch(); 1927 __ Dispatch();
1925 } 1928 }
1926 1929
1927 } // namespace interpreter 1930 } // namespace interpreter
1928 } // namespace internal 1931 } // namespace internal
1929 } // namespace v8 1932 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698