Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1811323002: [Interpreter] Add ignition compile trace events. (Closed)

Created:
4 years, 9 months ago by rmcilroy
Modified:
4 years, 9 months ago
CC:
oth, rmcilroy, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add ignition compile trace events. BUG=v8:4280 LOG=N Committed: https://crrev.com/3b537f380f0bacd62bd7c4010312b14666bffd87 Cr-Commit-Position: refs/heads/master@{#34899}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/interpreter/interpreter.cc View 1 chunk +3 lines, -0 lines 2 comments Download
M src/log.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
rmcilroy
Jochen, PTAL, thanks.
4 years, 9 months ago (2016-03-18 11:15:21 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811323002/1
4 years, 9 months ago (2016-03-18 11:33:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 12:14:32 UTC) #6
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1811323002/diff/1/src/interpreter/interpreter.cc File src/interpreter/interpreter.cc (right): https://codereview.chromium.org/1811323002/diff/1/src/interpreter/interpreter.cc#newcode69 src/interpreter/interpreter.cc:69: TimerEventScope<TimerEventCompileIgnition> timer(info->isolate()); why both a timer event scope and ...
4 years, 9 months ago (2016-03-18 12:40:31 UTC) #7
rmcilroy
https://codereview.chromium.org/1811323002/diff/1/src/interpreter/interpreter.cc File src/interpreter/interpreter.cc (right): https://codereview.chromium.org/1811323002/diff/1/src/interpreter/interpreter.cc#newcode69 src/interpreter/interpreter.cc:69: TimerEventScope<TimerEventCompileIgnition> timer(info->isolate()); On 2016/03/18 12:40:31, jochen wrote: > why ...
4 years, 9 months ago (2016-03-18 12:42:45 UTC) #8
jochen (gone - plz use gerrit)
*shrug* it's not needed for telemetry, but lgtm either way
4 years, 9 months ago (2016-03-18 15:30:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811323002/1
4 years, 9 months ago (2016-03-18 15:32:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 15:34:05 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 15:35:06 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b537f380f0bacd62bd7c4010312b14666bffd87
Cr-Commit-Position: refs/heads/master@{#34899}

Powered by Google App Engine
This is Rietveld 408576698