Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1811263002: [serializer] tweak startup serializer for warming up. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
vogelheim
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] tweak startup serializer for warming up. Code that we want to keep after warming up may have context-dependent inline caches. Clear these to avoid running into IC misses after deserialization. R=vogelheim@chromium.org BUG=v8:4836 LOG=N Committed: https://crrev.com/18cdb9cd48ff56e29d2d8c54216a4939e5964b67 Cr-Commit-Position: refs/heads/master@{#34945}

Patch Set 1 #

Patch Set 2 : open new handlescope #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -15 lines) Patch
M src/api.cc View 1 2 1 chunk +9 lines, -5 lines 0 comments Download
M src/snapshot/startup-serializer.cc View 1 chunk +18 lines, -10 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Yang
4 years, 9 months ago (2016-03-18 05:56:56 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811263002/1
4 years, 9 months ago (2016-03-18 07:28:20 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 08:14:44 UTC) #5
vogelheim
lgtm
4 years, 9 months ago (2016-03-18 09:49:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811263002/20001
4 years, 9 months ago (2016-03-18 10:15:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/15544) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-18 10:17:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811263002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811263002/40001
4 years, 9 months ago (2016-03-21 12:18:35 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-21 14:29:34 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-21 14:30:24 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/18cdb9cd48ff56e29d2d8c54216a4939e5964b67
Cr-Commit-Position: refs/heads/master@{#34945}

Powered by Google App Engine
This is Rietveld 408576698