Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1811203002: Remove unused ShelfModelObserver::ShelfStatusChanged() (Closed)

Created:
4 years, 9 months ago by msw
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused ShelfModelObserver::ShelfStatusChanged() BUG=NONE TEST=NONE R=sky@chromium.org Committed: https://crrev.com/25fc4e8f94f8279264116e32a9cc5361170154fc Cr-Commit-Position: refs/heads/master@{#381842}

Patch Set 1 #

Patch Set 2 : Make SetStatus a simple setter, set_status. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -38 lines) Patch
M ash/shelf/shelf_item_delegate_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_item_delegate_manager.cc View 2 chunks +3 lines, -9 lines 0 comments Download
M ash/shelf/shelf_model.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_model.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M ash/shelf/shelf_model_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shelf/shelf_model_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
msw
Hey Scott, please take a look; thanks!
4 years, 9 months ago (2016-03-17 23:28:47 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811203002/20001
4 years, 9 months ago (2016-03-17 23:29:41 UTC) #3
sky
LGTM
4 years, 9 months ago (2016-03-18 00:02:26 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 00:04:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811203002/20001
4 years, 9 months ago (2016-03-18 00:07:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-18 00:13:17 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 00:14:43 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/25fc4e8f94f8279264116e32a9cc5361170154fc
Cr-Commit-Position: refs/heads/master@{#381842}

Powered by Google App Engine
This is Rietveld 408576698