Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: libraries/python/nacl-python.sh

Issue 18112024: Fix python to build with newlib. (Closed) Base URL: https://naclports.googlecode.com/svn/trunk/src
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: libraries/python/nacl-python.sh
diff --git a/libraries/python/nacl-python.sh b/libraries/python/nacl-python.sh
index 09ebb4a5b573edc9b9482ef3f524d635bd7fe809..52b564a234b727bbfb52b09600fed9603acfafa4 100755
--- a/libraries/python/nacl-python.sh
+++ b/libraries/python/nacl-python.sh
@@ -10,8 +10,6 @@ EXECUTABLES=python.nexe
# Currently this package only builds on linux.
# The build relies on certain host binaries and pythong's configure
# requires us to sett --build= as well as --host=.
-EXTRA_CONFIGURE_ARGS="--disable-ipv6 --with-suffix=.nexe --build=x86_64-linux-gnu"
-export MAKEFLAGS="PGEN=../build-nacl-host/Parser/pgen"
HERE=$(cd "$(dirname "$BASH_SOURCE")" ; pwd)
BuildHostPython() {
@@ -28,7 +26,12 @@ CustomConfigureStep() {
# We pre-seed configure with certain results that it cannot determine
# since we are doing a cross compile. The $CONFIG_SITE file is sourced
# by configure early on.
+ EXTRA_CONFIGURE_ARGS+=" --disable-ipv6"
Mark Seaborn 2013/07/12 19:47:29 Can you comment why this is needed? What fails wi
Sam Clegg 2013/07/12 21:54:29 I'm just moving this from above, but you are right
+ EXTRA_CONFIGURE_ARGS+=" --with-suffix=.nexe"
+ EXTRA_CONFIGURE_ARGS+=" --build=x86_64-linux-gnu"
+ export MAKEFLAGS="PGEN=../build-nacl-host/Parser/pgen"
export CONFIG_SITE=${HERE}/config.site
+ export LIBS="-lc -lnosys"
Mark Seaborn 2013/07/12 19:47:29 "-lc" should be implicit. Can you omit that and j
Sam Clegg 2013/07/12 21:54:29 I found that I needed to put -lnosys after -lc (wh
DefaultConfigureStep
}

Powered by Google App Engine
This is Rietveld 408576698