Issue 18112019: Have Window inherit EventTarget interface

Issue 18112019: Have Window inherit EventTarget interface (Closed)

Created:
7 years, 5 months ago by do-not-use

Modified:
7 years, 5 months ago

Reviewers:
haraken, arv (Not doing code reviews), abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use, lgombos, dominicc (has gone to gerrit)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Have Window inherit EventTarget interface Have Window inherit EventTarget interface to match the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/browsers.html#the-window-object The implementation of addEventListener() / removeEventListener() needs an additional security check for the Window object so we leverage EventTarget::toDOMWindow() virtual method to make the check at run time. BUG=257583 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153926

Patch Set 1 #

Total comments: 3

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -69 lines)			Patch
M	LayoutTests/webexposed/event-target-in-prototype-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/scripts/deprecated_code_generator_v8.pm	View	1 chunk	+12 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	3 chunks	+21 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/custom/V8WindowCustom.cpp	View	1 chunk	+0 lines, -54 lines	3 comments	Download
M	Source/core/page/Window.idl	View	2 chunks	+1 line, -11 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM, but abarth might want to take another look. https://codereview.chromium.org/18112019/diff/1/Source/bindings/v8/custom/V8WindowCustom.cpp File Source/bindings/v8/custom/V8WindowCustom.cpp (left): https://codereview.chromium.org/18112019/diff/1/Source/bindings/v8/custom/V8WindowCustom.cpp#oldcode251 Source/bindings/v8/custom/V8WindowCustom.cpp:251: ...

7 years, 5 months ago (2013-07-10 13:07:57 UTC) #2

do-not-use

https://codereview.chromium.org/18112019/diff/1/Source/bindings/v8/custom/V8WindowCustom.cpp File Source/bindings/v8/custom/V8WindowCustom.cpp (left): https://codereview.chromium.org/18112019/diff/1/Source/bindings/v8/custom/V8WindowCustom.cpp#oldcode251 Source/bindings/v8/custom/V8WindowCustom.cpp:251: if (!imp->frame()) On 2013/07/10 13:07:57, haraken wrote: > > ...

7 years, 5 months ago (2013-07-10 13:16:52 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/18112019/1

7 years, 5 months ago (2013-07-10 18:17:31 UTC) #6

Message was sent while issue was closed.

Change committed as 153926

Expand Messages | Collapse Messages