Cleanup the UseSharedProxies preference.

chrome/browser/chromeos/net/proxy_config_handler.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/net/proxy_config_handler.h"
 
 #include "base/bind.h"
 #include "base/json/json_writer.h"
 #include "base/logging.h"
 #include "base/values.h"
 #include "chrome/browser/prefs/proxy_config_dictionary.h"
+#include "chrome/common/pref_names.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/shill_service_client.h"
 #include "chromeos/network/network_handler_callbacks.h"
 #include "chromeos/network/network_state.h"
 #include "chromeos/network/network_state_handler.h"
+#include "components/user_prefs/pref_registry_syncable.h"
 #include "dbus/object_path.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace chromeos {
 
 namespace proxy_config {
 
 scoped_ptr<ProxyConfigDictionary> GetProxyConfigForNetwork(
     const NetworkState& network) {
   const base::DictionaryValue& value = network.proxy_config();
@@ skipping 30 matching lines @@
                    "SetProxyConfig.SetProperty Failed",
                    network.path(), network_handler::ErrorCallback()));
   }
 
   if (NetworkHandler::IsInitialized()) {
     NetworkHandler::Get()->network_state_handler()->
         RequestUpdateForNetwork(network.path());
   }
 }
 
+void RegisterProfilePrefs(
+    user_prefs::PrefRegistrySyncable* registry) {
+  registry->RegisterBooleanPref(

[battre, 2013/07/11 13:31:23]

Can you please improve the comment at the definition of kUseSharedProxies? I
find "A boolean pref that uses shared proxies." pretty useless.
1) A pref does not use proxies
2) Who shares the proxies?
3) What is the meaning of this pref on Desktop

[pneubeck (no reviews), 2013/07/12 09:42:30]

3) doesn't apply as it's defined only for ChromeOS
Clarified the comment.

+      prefs::kUseSharedProxies,
+      false,
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+}
+
 }  // namespace proxy_config
 
 }  // namespace chromeos