Add PRESUBMIT.py file to net/websockets

Add PRESUBMIT.py file to net/websockets

Keep the README file up-to-date by warning people who don't update it. Include
PRESUBMIT.py in the README file so that it doesn't warn about itself.

We intentionally don't warn about existing errors in README. We also don't warn
in the case of deletions (too rare to be worth coding for).

Tested cases:

No files in CL - no warning
One added file in CL - warning
One added file in CL, README changed but with typo - warning
One added + one modified file in CL - warning for added file
One added + one modified file which is missing from README in CL
    - warning for added file
One added + one deleted file in CL - warning for added file
One added + one deleted file which was missing from README in CL
    - warning for added file
One added file also added to README - no warning
Two added files, one in README - warns about the file not in README
One file modified - no warning
One file deleted - no warning

BUG=258767
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=211387

[yhirano, 2013-07-11 01:44:34]

https://codereview.chromium.org/18112015/diff/1/net/websockets/PRESUBMIT.py
File net/websockets/PRESUBMIT.py (right):

https://codereview.chromium.org/18112015/diff/1/net/websockets/PRESUBMIT.py#n...
net/websockets/PRESUBMIT.py:31: added_source_files = [af for af in
input_api.AffectedSourceFiles(None)
Maybe you can delete added_source_files by creating added_source_filenames
directly.

https://codereview.chromium.org/18112015/diff/1/net/websockets/PRESUBMIT.py#n...
net/websockets/PRESUBMIT.py:43: for line in readme[0].NewContents():
Can you introduce readme_added_filenames = set([line.strip() for line in
readme[0].NewContents() if line.strip() in added_source_files])

and rewrite the following lines by set operations?
http://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset

[yhirano, 2013-07-11 01:47:35]

https://codereview.chromium.org/18112015/diff/1/net/websockets/PRESUBMIT.py
File net/websockets/PRESUBMIT.py (right):

https://codereview.chromium.org/18112015/diff/1/net/websockets/PRESUBMIT.py#n...
net/websockets/PRESUBMIT.py:43: for line in readme[0].NewContents():
On 2013/07/11 01:44:34, yhirano wrote:
> Can you introduce readme_added_filenames = set([line.strip() for line in
> readme[0].NewContents() if line.strip() in added_source_files])
> 
> and rewrite the following lines by set operations?
> http://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset

rewrite the following lines by using set operations, I meant. Sorry for my poor
English...

[Adam Rice, 2013-07-11 06:42:36]

https://codereview.chromium.org/18112015/diff/1/net/websockets/PRESUBMIT.py
File net/websockets/PRESUBMIT.py (right):

https://codereview.chromium.org/18112015/diff/1/net/websockets/PRESUBMIT.py#n...
net/websockets/PRESUBMIT.py:31: added_source_files = [af for af in
input_api.AffectedSourceFiles(None)
On 2013/07/11 01:44:34, yhirano wrote:
> Maybe you can delete added_source_files by creating added_source_filenames
> directly.

Good idea, thank you.

https://codereview.chromium.org/18112015/diff/1/net/websockets/PRESUBMIT.py#n...
net/websockets/PRESUBMIT.py:43: for line in readme[0].NewContents():
On 2013/07/11 01:44:34, yhirano wrote:
> Can you introduce readme_added_filenames = set([line.strip() for line in
> readme[0].NewContents() if line.strip() in added_source_files])
> 
> and rewrite the following lines by set operations?
> http://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset

Very nice. Implemented.

https://codereview.chromium.org/18112015/diff/1/net/websockets/PRESUBMIT.py#n...
net/websockets/PRESUBMIT.py:43: for line in readme[0].NewContents():
On 2013/07/11 01:47:35, yhirano wrote:
> On 2013/07/11 01:44:34, yhirano wrote:
> > Can you introduce readme_added_filenames = set([line.strip() for line in
> > readme[0].NewContents() if line.strip() in added_source_files])
> > 
> > and rewrite the following lines by set operations?
> > http://docs.python.org/2/library/stdtypes.html#set-types-set-frozenset
> 
> rewrite the following lines by using set operations, I meant. Sorry for my
poor
> English...

No problem. I understood what you meant.

[yhirano, 2013-07-11 06:49:43]

lgtm

[Adam Rice, 2013-07-11 06:56:08]

+tyoshino for OWNERS review.

[tyoshino (SeeGerritForStatus), 2013-07-11 09:26:54]

LGTM

https://codereview.chromium.org/18112015/diff/6001/net/websockets/PRESUBMIT.py
File net/websockets/PRESUBMIT.py (right):

https://codereview.chromium.org/18112015/diff/6001/net/websockets/PRESUBMIT.p...
net/websockets/PRESUBMIT.py:14: def CheckReadMeComplete(input_api, output_api):
Add '_' prefix to CheckReadMeComplete?

https://codereview.chromium.org/18112015/diff/6001/net/websockets/PRESUBMIT.p...
net/websockets/PRESUBMIT.py:58: def CheckChangeOnUpload(input_api, output_api):
It seems only CheckChangeOnUpload and CheckChangeOnCommit must have the method
name specified by the presubmit spec. Can't you just call
CheckReadMeComplete(input_api, output_api) from these functions?

[Adam Rice, 2013-07-11 09:46:20]

https://codereview.chromium.org/18112015/diff/6001/net/websockets/PRESUBMIT.py
File net/websockets/PRESUBMIT.py (right):

https://codereview.chromium.org/18112015/diff/6001/net/websockets/PRESUBMIT.p...
net/websockets/PRESUBMIT.py:14: def CheckReadMeComplete(input_api, output_api):
On 2013/07/11 09:26:54, tyoshino wrote:
> Add '_' prefix to CheckReadMeComplete?

Done.

https://codereview.chromium.org/18112015/diff/6001/net/websockets/PRESUBMIT.p...
net/websockets/PRESUBMIT.py:58: def CheckChangeOnUpload(input_api, output_api):
On 2013/07/11 09:26:54, tyoshino wrote:
> It seems only CheckChangeOnUpload and CheckChangeOnCommit must have the method
> name specified by the presubmit spec. Can't you just call
> CheckReadMeComplete(input_api, output_api) from these functions?

Yes. I included CheckChange() so it would be easy to add more checks in future,
but it is not needed.

[commit-bot: I haz the power, 2013-07-11 13:51:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ricea@chromium.org/18112015/15001

[commit-bot: I haz the power, 2013-07-11 15:04:55]

Retried try job too often on mac_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-07-12 12:32:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ricea@chromium.org/18112015/15001

[commit-bot: I haz the power, 2013-07-12 13:12:18]

Change committed as 211387