Support per-library serialization.

Support per-library serialization.

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/4b4718a53cc45f056437c62a7817e9c995980f00

[Johnni Winther, 2016-03-18 17:35:17]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2016-03-18 20:00:20]

lgtm

https://codereview.chromium.org/1811173003/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/serialization.dart (right):

https://codereview.chromium.org/1811173003/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/serialization.dart:589: typedef bool
IncludeElementFunction(Element element);
IncludeElementFunction => ElementMatcher

https://codereview.chromium.org/1811173003/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/serialization.dart:629:
IncludeElementFunction includeElement;
rename to `shouldInclude`:

  ElementMatcher shouldInclude;

https://codereview.chromium.org/1811173003/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/serialization.dart:681:
encoder.setValue(Key.CLASS, classId);
Just to check: does the classId include the library id?

https://codereview.chromium.org/1811173003/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization_library_test.dart (right):

https://codereview.chromium.org/1811173003/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization_library_test.dart:47: print("Multiple
entrypoints is not supported.");
is => are :)?

https://codereview.chromium.org/1811173003/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization_test.dart (right):

https://codereview.chromium.org/1811173003/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization_test.dart:653: //print('Checking class
members of ${element1} vs ${element2} (${element2.runtimeType})');
delete this and other commented lines above?

[Johnni Winther, 2016-03-29 09:05:55]

https://codereview.chromium.org/1811173003/diff/1/pkg/compiler/lib/src/serial...
File pkg/compiler/lib/src/serialization/serialization.dart (right):

https://codereview.chromium.org/1811173003/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/serialization.dart:589: typedef bool
IncludeElementFunction(Element element);
On 2016/03/18 20:00:20, Siggi Cherem (dart-lang) wrote:
> IncludeElementFunction => ElementMatcher

Done.

https://codereview.chromium.org/1811173003/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/serialization.dart:629:
IncludeElementFunction includeElement;
On 2016/03/18 20:00:20, Siggi Cherem (dart-lang) wrote:
> rename to `shouldInclude`:
> 
>   ElementMatcher shouldInclude;

Done.

https://codereview.chromium.org/1811173003/diff/1/pkg/compiler/lib/src/serial...
pkg/compiler/lib/src/serialization/serialization.dart:681:
encoder.setValue(Key.CLASS, classId);
On 2016/03/18 20:00:20, Siggi Cherem (dart-lang) wrote:
> Just to check: does the classId include the library id?

The class will be an EXTERNAL_LIBRARY_MEMBER, which stores a library id.

https://codereview.chromium.org/1811173003/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization_library_test.dart (right):

https://codereview.chromium.org/1811173003/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization_library_test.dart:47: print("Multiple
entrypoints is not supported.");
On 2016/03/18 20:00:20, Siggi Cherem (dart-lang) wrote:
> is => are :)?

Done.

https://codereview.chromium.org/1811173003/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization_test.dart (right):

https://codereview.chromium.org/1811173003/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization_test.dart:653: //print('Checking class
members of ${element1} vs ${element2} (${element2.runtimeType})');
On 2016/03/18 20:00:20, Siggi Cherem (dart-lang) wrote:
> delete this and other commented lines above?

Done.

[Johnni Winther, 2016-03-29 09:28:13]

Description was changed from

==========
Support per-library serialization.

BUG=
==========

to

==========
Support per-library serialization.

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4b4718a53cc45f056437c62a7817e9c995980f00
==========

[Johnni Winther, 2016-03-29 09:28:15]

Committed patchset #2 (id:20001) manually as
4b4718a53cc45f056437c62a7817e9c995980f00 (presubmit successful).