trunk/src/content/browser/frame_host/render_frame_host_manager_unittest.cc - Issue 181113009: Revert 253010 "Revert 251563 "Move browser initiated navigation ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 181113009: Revert 253010 "Revert 251563 "Move browser initiated navigation ..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/content/browser/frame_host/render_frame_host_manager_unittest.cc

===================================================================

--- trunk/src/content/browser/frame_host/render_frame_host_manager_unittest.cc (revision 254165)

+++ trunk/src/content/browser/frame_host/render_frame_host_manager_unittest.cc (working copy)

@@ -756,7 +756,7 @@

test_process_host2->sink().ClearMessages();

host2->render_view_host()->NavigateToURL(kUrl2);

EXPECT_FALSE(test_process_host2->sink().GetUniqueMessageMatching(

- ViewMsg_Navigate::ID));

+ FrameMsg_Navigate::ID));

// Allow closing the current Render View (precondition for swapping out

// the RVH): Simulate response from RenderView for ViewMsg_ShouldClose sent by

@@ -783,7 +783,7 @@

EXPECT_EQ(host2, manager->pending_frame_host());

// There should be still no navigation messages being sent.

EXPECT_FALSE(test_process_host2->sink().GetUniqueMessageMatching(

- ViewMsg_Navigate::ID));

+ FrameMsg_Navigate::ID));

// 3) Cross-site navigate to next site before 2) has committed. --------------

const GURL kUrl3("http://webkit.org/");