Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: trunk/src/chrome/test/chromedriver/chrome/navigation_tracker.cc

Issue 181113009: Revert 253010 "Revert 251563 "Move browser initiated navigation ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/test/chromedriver/chrome/navigation_tracker.cc
===================================================================
--- trunk/src/chrome/test/chromedriver/chrome/navigation_tracker.cc (revision 254165)
+++ trunk/src/chrome/test/chromedriver/chrome/navigation_tracker.cc (working copy)
@@ -131,20 +131,22 @@
// it is unknown what will happen.
//
// There are a few cases (perhaps more):
- // 1 The RenderViewHost has already queued ViewMsg_Navigate and loading
+ // 1 The RenderFrameHost has already queued FrameMsg_Navigate and loading
// will start shortly.
- // 2 The RenderViewHost has already queued ViewMsg_Navigate and loading
+ // 2 The RenderFrameHost has already queued FrameMsg_Navigate and loading
// will never start because it is just an in-page fragment navigation.
- // 3 The RenderViewHost is suspended and hasn't queued ViewMsg_Navigate
- // yet. This happens for cross-site navigations. The RenderViewHost
- // will not queue ViewMsg_Navigate until it is ready to unload the
+ // 3 The RenderFrameHost is suspended and hasn't queued FrameMsg_Navigate
+ // yet. This happens for cross-site navigations. The RenderFrameHost
+ // will not queue FrameMsg_Navigate until it is ready to unload the
// previous page (after running unload handlers and such).
+ // TODO(nasko): Revisit case 3, since now unload handlers are run in the
+ // background. http://crbug.com/323528.
//
// To determine whether a load is expected, do a round trip to the
// renderer to ask what the URL is.
// If case #1, by the time the command returns, the frame started to load
// event will also have been received, since the DevTools command will
- // be queued behind ViewMsg_Navigate.
+ // be queued behind FrameMsg_Navigate.
// If case #2, by the time the command returns, the navigation will
// have already happened, although no frame start/stop events will have
// been received.
« no previous file with comments | « no previous file | trunk/src/content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698