Issue 181113008: Revert "Remove Script::SetData and the script_data parameter from Script::(Compile|New)."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 181113008: Revert "Remove Script::SetData and the script_data parameter from Script::(Compile|New)." (Closed)

Created:
6 years, 9 months ago by marja

Modified:
6 years, 9 months ago

Reviewers:
Sven Panne, marja

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Remove Script::SetData and the script_data parameter from Script::(Compile|New)." This reverts revision 19616. BUG= TBR=marja@chromium.org,svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19618

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+182 lines, -13 lines)			Patch
M	include/v8.h	View	4 chunks	+22 lines, -3 lines	0 comments	Download
M	src/accessors.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/accessors.cc	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/api.cc	View	6 chunks	+40 lines, -5 lines	0 comments	Download
M	src/bootstrapper.cc	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	src/compiler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/debug.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/factory.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/liveedit.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/objects-debug.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects-printer.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/cctest/test-api.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	test/cctest/test-compiler.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	9 chunks	+67 lines, -3 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

marja

6 years, 9 months ago (2014-02-28 14:10:06 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r19618 (tree was closed).