Omnibox Logging - Clear Both Counterfactual Bits on ResetSession() Call

Omnibox Logging - Clear Both Counterfactual Bits on ResetSession() Call

It's weird to have the triggered bit set while the triggered_in_session
bit is not set.  This can happen in weird edge conditions.  For example,
type something in tab A, type something else in tab B where this
something else triggers the field trial, switch back to tab A and
press enter to navigate without typing anything new.  The switching tabs
will cause a ResetSession() call, clearing the triggered_in_session bit.
Yet the triggered bit does not get cleared; it only gets set/reset upon
user typing (i.e., a call to SearchProvider).  Thus, we have this
inconsistency.

Really, conceptually if we send ResetSession() calls at the appropriate
times, it should clear all the bits.

BUG=593434
Committed: https://crrev.com/1b55e348738d640be85412d8400e3cb5ef46d52e
Cr-Commit-Position: refs/heads/master@{#382181}

[Mark P, 2016-03-18 04:29:40]

Description was changed from

==========
Omnibox Logging - Clear Both Counterfactual Bits on ResetSession() Call

It's weird to have the triggered bit set while the triggered_in_session
bit is not set.  This can happen in weird edge conditions.  For example,
type something in tab A, type something else in tab B where this
something else triggers the field trial, switch back to tab A and
press enter to navigate without typing anything new.  The switching tabs
will cause a ResetSession() call, clearing the triggered_in_session bit.
Yet the triggered bit does not get cleared; it only gets set/reset upon
user typing (i.e., a call to SearchProvider).  Thus, we have this
inconsistency.

Really, conceptually if we send ResetSession() calls at the appropriate
times, it should clear all the bits.

BUG=593434
==========

to

==========
Omnibox Logging - Clear Both Counterfactual Bits on ResetSession() Call

It's weird to have the triggered bit set while the triggered_in_session
bit is not set.  This can happen in weird edge conditions.  For example,
type something in tab A, type something else in tab B where this
something else triggers the field trial, switch back to tab A and
press enter to navigate without typing anything new.  The switching tabs
will cause a ResetSession() call, clearing the triggered_in_session bit.
Yet the triggered bit does not get cleared; it only gets set/reset upon
user typing (i.e., a call to SearchProvider).  Thus, we have this
inconsistency.

Really, conceptually if we send ResetSession() calls at the appropriate
times, it should clear all the bits.

BUG=593434
==========

[Mark P, 2016-03-18 04:29:40]

mpearson@chromium.org changed reviewers:
+ hfung@chromium.org, pkasting@chromium.org

[Mark P, 2016-03-18 04:30:06]

Please take a look guys.

thanks,
mark

[Peter Kasting, 2016-03-18 04:55:29]

RS LGTM; I can't remember what these do or advise on whether it's possible to
collapse them into one item.

[Mark P, 2016-03-18 16:53:04]

On 2016/03/18 04:55:29, Peter Kasting wrote:
> RS LGTM; I can't remember what these do or advise on whether it's possible to
> collapse them into one item.

They're definitely not possible to collapse.

--mark

[H Fung, 2016-03-18 23:08:06]

lgtm

I'm not sure how you found this obscure case :)

[Mark P, 2016-03-18 23:20:32]

The CQ bit was checked by mpearson@chromium.org

[commit-bot: I haz the power, 2016-03-18 23:21:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811123003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811123003/1

[commit-bot: I haz the power, 2016-03-19 00:17:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-19 00:17:21]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark P, 2016-03-19 03:45:15]

Forgot to update the test.  Now done.

[Mark P, 2016-03-19 03:45:19]

The CQ bit was checked by mpearson@chromium.org

[Mark P, 2016-03-19 03:45:19]

The patchset sent to the CQ was uploaded after l-g-t-m from hfung@chromium.org,
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1811123003/#ps20001
(title: "update test")

[commit-bot: I haz the power, 2016-03-19 03:45:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811123003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811123003/20001

[commit-bot: I haz the power, 2016-03-19 04:36:27]

Description was changed from

==========
Omnibox Logging - Clear Both Counterfactual Bits on ResetSession() Call

It's weird to have the triggered bit set while the triggered_in_session
bit is not set.  This can happen in weird edge conditions.  For example,
type something in tab A, type something else in tab B where this
something else triggers the field trial, switch back to tab A and
press enter to navigate without typing anything new.  The switching tabs
will cause a ResetSession() call, clearing the triggered_in_session bit.
Yet the triggered bit does not get cleared; it only gets set/reset upon
user typing (i.e., a call to SearchProvider).  Thus, we have this
inconsistency.

Really, conceptually if we send ResetSession() calls at the appropriate
times, it should clear all the bits.

BUG=593434
==========

to

==========
Omnibox Logging - Clear Both Counterfactual Bits on ResetSession() Call

It's weird to have the triggered bit set while the triggered_in_session
bit is not set.  This can happen in weird edge conditions.  For example,
type something in tab A, type something else in tab B where this
something else triggers the field trial, switch back to tab A and
press enter to navigate without typing anything new.  The switching tabs
will cause a ResetSession() call, clearing the triggered_in_session bit.
Yet the triggered bit does not get cleared; it only gets set/reset upon
user typing (i.e., a call to SearchProvider).  Thus, we have this
inconsistency.

Really, conceptually if we send ResetSession() calls at the appropriate
times, it should clear all the bits.

BUG=593434
==========

[commit-bot: I haz the power, 2016-03-19 04:36:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-19 04:42:21]

Description was changed from

==========
Omnibox Logging - Clear Both Counterfactual Bits on ResetSession() Call

It's weird to have the triggered bit set while the triggered_in_session
bit is not set.  This can happen in weird edge conditions.  For example,
type something in tab A, type something else in tab B where this
something else triggers the field trial, switch back to tab A and
press enter to navigate without typing anything new.  The switching tabs
will cause a ResetSession() call, clearing the triggered_in_session bit.
Yet the triggered bit does not get cleared; it only gets set/reset upon
user typing (i.e., a call to SearchProvider).  Thus, we have this
inconsistency.

Really, conceptually if we send ResetSession() calls at the appropriate
times, it should clear all the bits.

BUG=593434
==========

to

==========
Omnibox Logging - Clear Both Counterfactual Bits on ResetSession() Call

It's weird to have the triggered bit set while the triggered_in_session
bit is not set.  This can happen in weird edge conditions.  For example,
type something in tab A, type something else in tab B where this
something else triggers the field trial, switch back to tab A and
press enter to navigate without typing anything new.  The switching tabs
will cause a ResetSession() call, clearing the triggered_in_session bit.
Yet the triggered bit does not get cleared; it only gets set/reset upon
user typing (i.e., a call to SearchProvider).  Thus, we have this
inconsistency.

Really, conceptually if we send ResetSession() calls at the appropriate
times, it should clear all the bits.

BUG=593434

Committed: https://crrev.com/1b55e348738d640be85412d8400e3cb5ef46d52e
Cr-Commit-Position: refs/heads/master@{#382181}
==========

[commit-bot: I haz the power, 2016-03-19 04:42:22]

Patchset 2 (id:??) landed as
https://crrev.com/1b55e348738d640be85412d8400e3cb5ef46d52e
Cr-Commit-Position: refs/heads/master@{#382181}