Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 1811113005: Temporarily switch the compiler back to VS2013 on DrMemory bots. (Closed)

Created:
4 years, 9 months ago by oshima
Modified:
4 years, 9 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, zhaoqin1, Derek Bruening
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Temporarily switch the compiler back to VS2013 on DrMemory bots. Because Too many tests are failing (~1000). I'll file a DrMemory issue. BUG=594808 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M masters/master.chromium.memory.fyi/master.cfg View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811113005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811113005/1
4 years, 9 months ago (2016-03-18 20:50:53 UTC) #4
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started ...
4 years, 9 months ago (2016-03-18 20:50:55 UTC) #6
Lei Zhang
lgtm
4 years, 9 months ago (2016-03-18 21:00:53 UTC) #8
oshima
+brucedawson@ : fyi
4 years, 9 months ago (2016-03-18 21:02:02 UTC) #9
brucedawson
On 2016/03/18 21:02:02, oshima wrote: > +brucedawson@ : fyi I agree that this is the ...
4 years, 9 months ago (2016-03-18 21:02:53 UTC) #10
brucedawson
On 2016/03/18 21:02:53, brucedawson wrote: > On 2016/03/18 21:02:02, oshima wrote: > > +brucedawson@ : ...
4 years, 9 months ago (2016-03-18 21:03:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811113005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811113005/1
4 years, 9 months ago (2016-03-18 21:04:39 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299388
4 years, 9 months ago (2016-03-18 21:07:56 UTC) #15
oshima
4 years, 9 months ago (2016-03-19 04:30:52 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1823453002/ by oshima@chromium.org.

The reason for reverting is: THe code base is no longer compatible with VS2013.
I'll exlucde failing tests instead..

Powered by Google App Engine
This is Rietveld 408576698