Issue 18111003: Eliminate --google-base-suggest-url. Its use cases will be addressed with the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18111003: Eliminate --google-base-suggest-url. Its use cases will be addressed with the (Closed)

Created:
7 years, 5 months ago by Peter Kasting

Modified:
7 years, 5 months ago

Reviewers:
H Fung

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Eliminate --google-base-suggest-url. Its use cases will be addressed with the upcoming --google-base-url. BUG=249197 TEST=none TBR=hfung Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208963

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -12 lines)			Patch
M	chrome/browser/search_engines/search_terms_data.cc	View	3 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

TBRing, since this was already LGTMed as part of https://codereview.chromium.org/17022004/ .

7 years, 5 months ago (2013-06-27 19:05:38 UTC) #1

H Fung

Did the GoogleBaseURLValue() changes get submitted? (I didn't see it in the base version of ...

7 years, 5 months ago (2013-06-28 06:33:55 UTC) #3

Peter Kasting

7 years, 5 months ago (2013-06-28 18:57:06 UTC) #4

Message was sent while issue was closed.

On 2013/06/28 06:33:55, H Fung wrote:
> Did the GoogleBaseURLValue() changes get submitted?  (I didn't see it in the
> base version of the patch, but I did not follow the comments at
> https://codereview.chromium.org/17022004/)

Not yet, hence the word "upcoming" in the description of this bug.  I split the
previous CL into a series of changes, and that one will be the next one up after
the current one lands.

Expand Messages | Collapse Messages